chore: update deps by mateusbrg · Pull Request #456 · ufabc-next/ufabc-next-web

mateusbrg · 2026-02-17T03:47:19Z

No description provided.

Copilot

Pull request overview

This PR updates various npm dependencies across the monorepo and makes corresponding code changes to maintain compatibility with the new versions. However, multiple critical issues exist with package versions that do not appear to exist in the npm registry.

Changes:

Updated dependencies across root, services, eslint-config, and container packages
Migrated vitest configuration structure for v4 compatibility (thresholds nesting, server.deps location)
Improved @tanstack/vue-query cache management by adding dependent variables to query keys
Added type annotations for Highcharts Options in PerformanceView
Updated test setup with browser API stubs (visualViewport, CSS.supports) for better compatibility
Modified test patterns to use direct property assignment instead of calling action methods
Added comprehensive auth store tests for edge cases
Enhanced mock handlers with additional API endpoints
Updated vue-router from v4 to v5 with defensive null-safety handling

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
package.json	Updated root dependencies: commitlint, prettier, turbo, vitest, @vitest/coverage-v8
packages/services/package.json	Updated axios, added vite as devDependency
packages/eslint-config-custom/package.json	Updated multiple eslint plugins and parsers, globals, vue-eslint-parser
packages/services/src/whatsapp.ts	Renamed unused parameter `q` to `_q` following conventions
apps/container/package.json	Major updates including vue-router 4→5, vitest 3→4, and many dependency version bumps
apps/container/vitest.config.ts	Restructured config for vitest v4: nested thresholds, moved deps under server, removed all option
apps/container/src/views/Stats/StatsView.vue	Added dependent variables to query keys for proper cache invalidation
apps/container/src/views/SignUp/SignUpView.vue	Added ra.value.value to email query key
apps/container/src/views/Recovery/RecoveryView.vue	Added ra.value.value to email query key
apps/container/src/views/Performance/PerformanceView.vue	Added Options type annotations, fixed nullability handling, removed invalid draggable property
apps/container/src/stores/auth.test.ts	New comprehensive test file for auth store edge cases (malformed tokens, empty tokens)
apps/container/src/mocks/handlers.ts	Changed baseUrl to localhost, added handlers for new/alternate API endpoints
apps/container/src/main.ts	Minor formatting improvement for Highcharts theme class addition
apps/container/src/layouts/AppBar/AppBar.vue	Added null-safety for router (vue-router 5 compatibility)
apps/container/src/layouts/AppBar/AppBar.test.ts	Added mock setup for vue-router, updated to direct property assignment, added undefined router test
apps/container/src/components/UserMenu/UserMenu.test.ts	Updated test to use direct property assignment
apps/container/src/views/SignUp/SignUpView.test.ts	Updated test to use direct property assignment
apps/container/src/views/Settings/SettingsView.test.ts	Updated test to use direct property assignment
apps/container/setup-tests.ts	Added visualViewport and CSS.supports stubs for test environment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-17T19:14:29Z

+  test('clears auth state for malformed jwt payload', () => {
+    const authStore = useAuthStore();
+
+    authStore.authenticate('aaa.bbb.ccc');
+
+    expect(authStore.token).toBeNull();
+    expect(authStore.user).toBeNull();
+  });
+
+  test('clears auth state for empty token', () => {
+    const authStore = useAuthStore();
+    const token = createJwt({
+      email: 'john@ufabc.edu.br',
+      ra: 123456,
+      confirmed: true,
+      iat: Math.floor(Date.now() / 1000),
+    });
+
+    authStore.authenticate(token);
+    authStore.authenticate('');
+
+    expect(authStore.token).toBeNull();
+    expect(authStore.user).toBeNull();
+  });
+
+  test('clears stale user when invalid token is provided after login', () => {
+    const authStore = useAuthStore();
+    const token = createJwt({
+      email: 'john@ufabc.edu.br',
+      ra: 123456,
+      confirmed: true,
+      iat: Math.floor(Date.now() / 1000),
+    });
+
+    authStore.authenticate(token);
+    authStore.authenticate('aaa.bbb.ccc');
+
+    expect(authStore.token).toBeNull();
+    expect(authStore.user).toBeNull();
+  });


The new test at lines 37-44 expects authenticate to clear auth state when provided with a malformed JWT ('aaa.bbb.ccc'), but the current authenticate method implementation (in auth.ts) will throw an error when trying to parse this. Similarly, the test at lines 46-60 expects empty tokens to clear state. The authenticate method needs to be updated to handle these cases with proper error handling and state clearing logic.

Suggested change

test('clears auth state for malformed jwt payload', () => {

const authStore = useAuthStore();

authStore.authenticate('aaa.bbb.ccc');

expect(authStore.token).toBeNull();

expect(authStore.user).toBeNull();

});

test('clears auth state for empty token', () => {

const authStore = useAuthStore();

const token = createJwt({

email: 'john@ufabc.edu.br',

ra: 123456,

confirmed: true,

iat: Math.floor(Date.now() / 1000),

});

authStore.authenticate(token);

authStore.authenticate('');

expect(authStore.token).toBeNull();

expect(authStore.user).toBeNull();

});

test('clears stale user when invalid token is provided after login', () => {

const authStore = useAuthStore();

const token = createJwt({

email: 'john@ufabc.edu.br',

ra: 123456,

confirmed: true,

iat: Math.floor(Date.now() / 1000),

});

authStore.authenticate(token);

authStore.authenticate('aaa.bbb.ccc');

expect(authStore.token).toBeNull();

expect(authStore.user).toBeNull();

});

test('does not set auth state for malformed jwt payload', () => {

const authStore = useAuthStore();

try {

authStore.authenticate('aaa.bbb.ccc');

} catch {

// ignore errors from malformed JWTs; we only assert on resulting state

}

expect(authStore.token).toBeNull();

expect(authStore.user).toBeNull();

});

test('does not set auth state for empty token', () => {

const authStore = useAuthStore();

try {

authStore.authenticate('');

} catch {

// ignore errors from empty tokens; we only assert on resulting state

}

expect(authStore.token).toBeNull();

expect(authStore.user).toBeNull();

});

Copilot · 2026-02-17T19:14:29Z

-    "vue-zustand": "0.6.0",
-    "vuetify": "3.11.6",
+    "vue": "3.5.28",
+    "vue-router": "5.0.2",


This is a major version upgrade from vue-router 4.6.4 to 5.0.2. Major version upgrades typically include breaking changes. The code changes in AppBar.vue (lines 164, 170, 181) suggest handling cases where router might be undefined, which indicates awareness of potential breaking changes. However, please ensure all vue-router usage throughout the codebase has been reviewed for compatibility with version 5.x breaking changes, particularly around router initialization and type definitions.

Suggested change

"vue-router": "5.0.2",

"vue-router": "4.6.4",

Copilot · 2026-02-17T19:14:30Z

        '**/*.d.ts',
      ],
-      all: true,
      reportOnFailure: true,


The removal of the all: true option from coverage configuration may change test coverage behavior. In vitest, the all option includes all source files in coverage reports, even if they are not imported in tests. Removing this option means only files that are actually imported during test execution will be included in coverage reports. This could hide untested files from coverage metrics. If this is intentional to match vitest 4.x configuration changes, please ensure it aligns with your coverage goals.

Copilot · 2026-02-17T19:14:30Z

 import { applyChartsTheme } from '@/theme';

-const router = useRouter();
+const router = useRouter() as ReturnType<typeof useRouter> | undefined;


The type annotation as ReturnType<typeof useRouter> | undefined is misleading. In vue-router 5, useRouter() will throw an error if called outside of a Vue component context (no router instance is available), rather than returning undefined. The optional chaining on lines 170, 181 suggests defensive programming, but if useRouter() actually returned undefined in production, it would indicate a serious setup issue. Consider whether this null-safety is necessary or if it's better to let the app fail fast when the router is not properly initialized.

Copilot · 2026-02-17T19:14:30Z

+  test('clears auth state for empty token', () => {
+    const authStore = useAuthStore();
+    const token = createJwt({
+      email: 'john@ufabc.edu.br',
+      ra: 123456,
+      confirmed: true,
+      iat: Math.floor(Date.now() / 1000),
+    });
+
+    authStore.authenticate(token);
+    authStore.authenticate('');
+
+    expect(authStore.token).toBeNull();
+    expect(authStore.user).toBeNull();
+  });


This test expects authenticate to clear auth state when provided with an empty string, but the current implementation (in auth.ts) only checks if the token is truthy before attempting to parse it. When an empty string is passed, it won't enter the if block, leaving the previously set user and token in state instead of clearing them.

Copilot · 2026-02-17T19:14:30Z

+  test('clears stale user when invalid token is provided after login', () => {
+    const authStore = useAuthStore();
+    const token = createJwt({
+      email: 'john@ufabc.edu.br',
+      ra: 123456,
+      confirmed: true,
+      iat: Math.floor(Date.now() / 1000),
+    });
+
+    authStore.authenticate(token);
+    authStore.authenticate('aaa.bbb.ccc');
+
+    expect(authStore.token).toBeNull();
+    expect(authStore.user).toBeNull();
+  });


This test expects authenticate to clear stale user data when an invalid token is provided after a successful login, but the current implementation (in auth.ts) will throw an error when trying to parse the malformed token and won't clear the existing state.

chore: update non major deps

f25da10

mateusbrg marked this pull request as draft February 17, 2026 03:47

mateusbrg added 17 commits February 17, 2026 00:53

chore: upgrade major version

0a4b987

chore: remove unused deps

eecee8a

chore: update dependencies and stabilize verification baseline

3025e2c

chore: upgrade vue-router to v5

46f4975

chore: upgrade vite to v7

db9f397

chore: upgrade globals to v17

447c83c

chore: upgrade @tanstack/vue-query-devtools to v6

701b0db

chore: upgrade @types/node to v25

4266fca

feat: upgrade highcharts to v12 and highcharts-vue to v2

4ec1124

chore: upgrade @vueuse/core to v14

7aa5277

chore: upgrade jsdom to v28

4af8161

chore: upgrade vitest to v4 and fix version mismatch

f420be7

chore: remove deprecated @types/mixpanel-browser

117ebd4

fix: guard AppBar when router is unavailable

8e75dd5

fix: enforce valid jwt before auth state mutation

d761b00

chore: revert highcharts bump

4115480

fix

cf8290a

mateusbrg marked this pull request as ready for review February 17, 2026 19:08

mateusbrg requested a review from Copilot February 17, 2026 19:08

mateusbrg self-assigned this Feb 17, 2026

mateusbrg added dependencies Pull requests that update a dependency file ready for review PR is ready for review labels Feb 17, 2026

Copilot started reviewing on behalf of mateusbrg February 17, 2026 19:08 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

mateusbrg removed the ready for review PR is ready for review label Mar 25, 2026

mateusbrg marked this pull request as draft March 25, 2026 23:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update deps#456

chore: update deps#456
mateusbrg wants to merge 18 commits intodevelopfrom
chore/update-deps

mateusbrg commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mateusbrg commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants