Update soto to 7.x (+ e2e Traefik/core-dump fixes) - #96
Merged
Conversation
Bump soto from 6.x to 7.14.0 (soto-core 7.14.0, async-http-client 1.30.1) and migrate TenantTemplateLoader to the soto 7 API: - AWSClient no longer takes httpClientProvider; it now defaults to the shared HTTPClient. Shutdown moved from syncShutdown() to the async shutdown() in a detached task. - S3.GetObjectOutput.body is now a non-optional streaming AWSHTTPBody; read it via collect(upTo:) and decode the resulting ByteBuffer.
The e2e Traefik install used an unpinned chart, so after a helm repo update it pulled the latest chart (41.x) whose values schema rejects Deployment/e2e/traefik/values.yaml (providers.file.content type change, removed podSecurityPolicy/logs, disallowed kubernetesIngressNginx). Pin to 38.0.2 (appVersion v3.6.6), the newest chart whose schema still matches the tracked values file, overridable via TRAEFIK_CHART_VERSION.
A WebKit minibrowser crash during e2e leaves a multi-GB ELF core dump at Tests/e2e/playwright/core. The root .gitignore's /core is anchored to the repo root and does not match it, so ignore core/core.* in the playwright test dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the soto AWS SDK from 6.x to 7.x and fixes two unrelated e2e/tooling breakages found along the way.
soto 6.x → 7.14.0
6.0.0→ 7.14.0, soto-core → 7.14.0, async-http-client1.29.0→ 1.30.1 (soto-core 7.14 requires AHC ≥1.30). soto 7 also enables theServiceLifecycleSupportpackage trait, which requires a trait-aware soto-core.TenantTemplateLoaderto the soto 7 API:AWSClientno longer takeshttpClientProvider; it now defaults to the sharedHTTPClient. Shutdown moved fromsyncShutdown()to the asyncshutdown().S3.GetObjectOutput.bodyis now a non-optional streamingAWSHTTPBody; read it viacollect(upTo:)and decode the resultingByteBuffer.e2e: pin Traefik Helm chart to 38.0.2
The e2e Traefik install used an unpinned chart, so
helm repo updatepulled the latest (41.x), whose values schema rejectsDeployment/e2e/traefik/values.yaml. Pinned to 38.0.2 (appVersion v3.6.6) — the newest chart whose schema still matches the tracked values file — overridable viaTRAEFIK_CHART_VERSION.e2e: ignore browser crash core dumps
A WebKit minibrowser crash during e2e leaves a multi-GB ELF core dump at
Tests/e2e/playwright/core. The root.gitignore's/coreis anchored to the repo root and doesn't match it, so addedcore/core.*ignores in the playwright test dir.Verification
swift buildandswift build --build-tests— clean (strict Swift 6 concurrency,-warnings-as-errors)./tooling.sh lint— 0 violationshelm template./tooling.sh e2e(needs kind cluster) and the S3 template-download path (no test covers it) — the soto migration is compile-verified only.