Add fullscreen window display mode for page actions#278
Add fullscreen window display mode for page actions#278
Conversation
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
…n-window-feature # Conflicts: # packages/extension/src/components/option/field/OpenModeToggleField.tsx
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 17.79% 17.79% -0.01%
==========================================
Files 307 307
Lines 28412 28447 +35
Branches 1185 1188 +3
==========================================
+ Hits 5056 5062 +6
- Misses 23356 23385 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PRレビュー: フルスクリーン表示モードの追加全体的に実装の方向性は正しく、主要なケース(フルスクリーンでの実行・録画)はカバーされています。ただし、いくつか修正が必要な問題と改善提案があります。 バグ:
|
Adds fullscreen as a fifth display mode option for page action commands, alongside popup, window, tab, and background tab.
Changes
Core Implementation
FULLSCREEN = "fullscreen"toPAGE_ACTION_OPEN_MODEenum (shared package)POPUP_TYPE.NORMALwindow, then applychrome.windows.update(windowId, { state: "fullscreen" })Services (
packages/extension/src/services/pageAction/background.ts)openAndRunPageAction: handles fullscreen mode during executionopenRecorder: supports fullscreen mode when recording actionsUI (
packages/extension/src/components/option/field/OpenModeToggleField.tsx)Localization
Example Usage
When creating or editing a page action command, users can now select fullscreen mode:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.google-analytics.com/opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development /home/REDACTED/work/selection-command/selection-command/node_modules/tinypool/dist/entry/process.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.