ssl client principal propagation by ujjwalkalia · Pull Request #1 · ujjwalkalia/kroxylicious

ujjwalkalia · 2025-06-02T13:41:52Z

Type of change

Select the type of your PR

Bugfix
Enhancement / new feature
Refactoring
Documentation

Description

Please describe your pull request

Additional Context

Why are you making this pull request?

Checklist

Please go through this checklist and make sure all applicable tasks have been done

PR raised from a fork of this repository and made from a branch rather than main.
Write tests
Update documentation
Make sure all unit/integration tests pass
Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
If applicable to the change, trigger the system test suite. Make sure tests pass.
If applicable to the change, trigger the performance test suite. Ensure that any degradations to performance numbers are understood and justified.
Ensure the PR references relevant issue(s) so they are closed on merging.
For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

NOTE: You must be a member of @kroxylicious/developers to trigger the system test and performance test suites. If you are not part of this group, comment on the PR requesting a trigger, tagging @kroxylicious/developers.

Uzziee · 2025-06-03T11:35:14Z

...ylicious-runtime/src/main/java/io/kroxylicious/proxy/internal/KafkaProxyFrontendHandler.java

+        return downStreamCertificatePrincipal;
+    }
+
+    private @Nullable String downStreamCertificatePrincipal;


nit: add this before getDownStreamCertificatePrincipal

Uzziee · 2025-06-03T11:36:03Z

...ylicious-runtime/src/main/java/io/kroxylicious/proxy/internal/KafkaProxyFrontendHandler.java

+                try {
+                    downStreamCertificatePrincipal = sslHandler.engine().getSession().getPeerPrincipal().toString();
+                } catch (SSLPeerUnverifiedException e) {
+                    LOGGER.debug("No client principal received, setting principal as ANONYMOUS");


Maybe add channel information in the logs ?
Lets check how kroxylicious adds debug logs

Uzziee · 2025-06-03T11:39:13Z

...ylicious-runtime/src/main/java/io/kroxylicious/proxy/internal/KafkaProxyFrontendHandler.java

+                    downStreamCertificatePrincipal = sslHandler.engine().getSession().getPeerPrincipal().toString();
+                } catch (SSLPeerUnverifiedException e) {
+                    LOGGER.debug("No client principal received, setting principal as ANONYMOUS");
+                    downStreamCertificatePrincipal = "ANONYMOUS";


Maybe this from KafkaPrincipal class from kafka ?

hrishabhg

LGTM. Expects few minor things to be taken care.

hrishabhg · 2025-06-03T12:25:17Z

kroxylicious-api/src/main/java/io/kroxylicious/proxy/filter/FilterContext.java

    String sniHostname();

+    @Nullable
+    String downStreamCertificatePrincipal();


Suggested change

String downStreamCertificatePrincipal();

String downstreamCertificatePrincipal();

hrishabhg · 2025-06-03T12:27:16Z

kroxylicious-api/src/main/java/io/kroxylicious/proxy/filter/FilterContext.java

    String sniHostname();

+    @Nullable
+    String downStreamCertificatePrincipal();


Did it not break during build? We should be backward compatible with existing impl of the interface. It should be

default String downStreamCertificatePrincipal() { return null; }

hrishabhg · 2025-06-03T12:29:05Z

...ylicious-runtime/src/main/java/io/kroxylicious/proxy/internal/KafkaProxyFrontendHandler.java

+                    downStreamCertificatePrincipal = sslHandler.engine().getSession().getPeerPrincipal().toString();
+                } catch (SSLPeerUnverifiedException e) {
+                    LOGGER.debug("No client principal received, setting principal as ANONYMOUS");
+                    downStreamCertificatePrincipal = "ANONYMOUS";


define constant.

This should be in finally. 2nd time ssl event should not return previously resolved value.

Suggested change

downStreamCertificatePrincipal = "ANONYMOUS";

downStreamCertificatePrincipal = ANONYMOUS;

log.warn or log.info instead of debug.

hrishabhg · 2025-06-03T12:42:03Z

...ious-runtime/src/test/java/io/kroxylicious/proxy/internal/KafkaProxyFrontendHandlerTest.java

    /**
     * Test the normal flow, in a number of configurations.
     *
+     * @param clientAuthConfigured


nit: add description

hrishabhg · 2025-06-03T12:46:07Z

kroxylicious-runtime/src/test/java/io/kroxylicious/proxy/internal/FilterHarness.java

                })) // reverses order
                .stream()
-                .map(f -> new FilterHandler(getOnlyElement(FilterAndInvoker.build(f.getClass().getSimpleName(), f)), timeoutMs, null, testVirtualCluster, inboundChannel))
+                .map(f -> new FilterHandler(getOnlyElement(FilterAndInvoker.build(f.getClass().getSimpleName(), f)), timeoutMs, null, null, testVirtualCluster, inboundChannel))


We should add parametrised test in FilterHandlerTest also to cover non-null scenario.
Add parameterised test for inheritors if needed.

Signed-off-by: Ujjwal <ukalia@confluent.io>

…nal (kroxylicious#2248) Signed-off-by: k-wall <18440250+k-wall@users.noreply.github.com> Co-authored-by: k-wall <18440250+k-wall@users.noreply.github.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

…2.6.9.Fi…" This reverts commit 6021132. Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.12.2 to 5.13.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.12.2...r5.13.0) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-version: 5.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Bumps [org.apache.maven.plugins:maven-clean-plugin](https://github.com/apache/maven-clean-plugin) from 3.4.1 to 3.5.0. - [Release notes](https://github.com/apache/maven-clean-plugin/releases) - [Commits](apache/maven-clean-plugin@maven-clean-plugin-3.4.1...maven-clean-plugin-3.5.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-clean-plugin dependency-version: 3.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 8 to 10. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v8...v10) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Co-authored-by: Keith Wall <kwall@redhat.com> Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

…etrics * Frame now carries api key id/version * pushed responsibility for emitting metrics to dedicated handlers. Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

…ponse Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Co-authored-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

…f API Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

sonar Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Did some other renaming to try and make things easier to grok. Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

If any referenced KafkaProxyIngress contains a loadBalancer property, we: 1. create a single Service with type LoadBalancer for the proxy. This is to be shared by all LoadBalancer ingresses. 2. add a shared-sni container port to the proxy, 9291. This is the port all of the shared Service ports will target. Then, for each loadbalancer KafkaProxyIngress referred to by a VKC we add a gateway to that VKC's proxy config. The gateway uses SNI and we pass through: - the bootstrapAddress from the KPI custom resource, with the shared-sni container port appended, as this is the address the proxy will listen on. - the advertisedBrokerAddressPattern from the KPI custom resource, with the client-facint Service port appended (currently defaulted to 9083) as this is the port clients will have to connect to. In future the port exposed by the shared Service for a KafkaProxyIngress will be customizable, the intent is that the shared Service will accumulate all the client-facing ports across all ingresses and map them all to the shared-sni port on the proxy container. We have not implemented VKC ingress status for loadbalancer ingresses yet. Signed-off-by: Robert Young <robeyoun@redhat.com> Co-authored-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Formatter didn't fix it as it was in a massive block of formatter off. Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

…ls to resolve to virtual cluster. Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: k-wall <18440250+k-wall@users.noreply.github.com> Co-authored-by: k-wall <18440250+k-wall@users.noreply.github.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

For TLS clusterIP ingress we manifest: 1. a bootstrap service named ${virtualClusterName}-${ingressName}, the same naming we use for the service carrying the TCP bootstrap port. 2. a service for each upstream node named like ${virtualClusterName}-${ingressName}-${upstreamNodeId}. 3. we configure the proxy virtual cluster gateway like: sniHostIdentifiesNode: bootstrapAddress: "${virtualClusterName}-${ingressName}.${proxyNamespace}.svc.cluster.local:9191" advertisedBrokerAddressPattern: "${virtualClusterName}-${ingressName}-$(nodeId).${proxyNamespace}.svc.cluster.local:9292" The user must ensure their downstream TLS certificates contain SANs for the bootstrap and each upstream node. Why: Previously we limited the user to a single VKC+ingress using identifying ports due to the risks of using port for identification (during reconciliation, the identity of a port can change, so clients could connect to an unexpected vcluster/node). By changing to SNI as the mechanism, the identity is unambiguous as VKCs/gateways are added and removed, as the hostnames should be stable and uniquely address a gateway bootstrap or node. So we can safely allow numerous TLS clusterIP ingresses to co-exist within a cluster without implementing a safer port allocation strategy for identifying ports. Signed-off-by: Robert Young <robeyoun@redhat.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

kubectl exited non-zero when we try to delete some resources, when k8s has no knowledge of those CRDs. This command is intended to clean out existing resources and CRDs from an established minikube, as well as install into a fresh minikube. So we can tactically ignore those failures. Signed-off-by: Robert Young <robeyoun@redhat.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Why: We want to be able to suffix the proxy name to create a shared LoadBalancer service. Limiting the KafkaProxy name gives us some wiggle room since we can only create Services with names up to 63 characters. Signed-off-by: Robert Young <robeyoun@redhat.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Fixes: kroxylicious#1852 Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

* first try Signed-off-by: Francisco Vila <fvila@redhat.com> * make olm installation work Signed-off-by: Francisco Vila <fvila@redhat.com> * added some default values Signed-off-by: Francisco Vila <fvila@redhat.com> * fix installation method Signed-off-by: Francisco Vila <fvila@redhat.com> * add olm deployment name as env variable Signed-off-by: Francisco Vila <fvila@redhat.com> * replace install type env variable Signed-off-by: Francisco Vila <fvila@redhat.com> * fix format Signed-off-by: Francisco Vila <fvila@redhat.com> * added undeclared dependencies Signed-off-by: Francisco Vila <fvila@redhat.com> * set new default value for olm deployement Signed-off-by: Francisco Vila <fvila@redhat.com> * small nits from Keith Signed-off-by: Francisco Vila <fvila@redhat.com> --------- Signed-off-by: Francisco Vila <fvila@redhat.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Uzziee reviewed Jun 3, 2025

View reviewed changes

hrishabhg approved these changes Jun 3, 2025

View reviewed changes

ujjwalkalia and others added 26 commits June 9, 2025 02:47

ssl client principal propagation

5691897

Signed-off-by: Ujjwal <ukalia@confluent.io>

additional changes

ba4bd94

Signed-off-by: Ujjwal <ukalia@confluent.io>

additional changes

1810078

Signed-off-by: Ujjwal <ukalia@confluent.io>

Update quay.io/apicurio/apicurio-registry-mem Docker tag to v2.6.9.Fi…

d2f3c92

…nal (kroxylicious#2248) Signed-off-by: k-wall <18440250+k-wall@users.noreply.github.com> Co-authored-by: k-wall <18440250+k-wall@users.noreply.github.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Revert "Update quay.io/apicurio/apicurio-registry-mem Docker tag to v…

7f0694b

…2.6.9.Fi…" This reverts commit 6021132. Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Enable remote debugging of the Operator

f129802

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Mention debug access in operator DEV_GUIDE.md

deec229

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

PR Review: typo fix

18cb11c

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Typo and grammer fixes

67c59f1

Co-authored-by: Keith Wall <kwall@redhat.com> Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Fix kroxylicious#2239: Downstream / upstream kafka message counting m…

85bbde8

…etrics * Frame now carries api key id/version * pushed responsibility for emitting metrics to dedicated handlers. Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Use api key/version from Frame rather than re-reading the written res…

8720ace

…ponse Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

sonar

3fa4031

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

bug fix - deprecated metrics wrong way about

c0465cc

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

sonar

30da5d3

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

more sonar

f09da5f

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

add unit test for new metrics handler

2e14c80

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Addressing code review comments.

cc0616a

Co-authored-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Make io.kroxylicious.proxy.internal.net.EndpointBinding#nodeId part o…

de686a9

…f API Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

adding short circuit IT

8df2041

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

tidy it

63daeb9

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

adding IT checking metrics are discriminated by node_id

47544a6

sonar Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Cert type thing in the system test

8cc665d

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Updating the cert causes the podTemplate updated.

3ceeea3

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

SamBarker and others added 28 commits June 9, 2025 02:47

Sonar nits

abedcf7

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

use the return value to make code analysis STFU

34d668a

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

stop things moaning about possible NPEs

1446612

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

PR Review: initialise workflowContext once

5d62ff8

Did some other renaming to try and make things easier to grok. Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Remove dead code

c69c058

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Simplify mocking

e84334b

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Add whitespace around assignment.

ce9274c

Formatter didn't fix it as it was in a massive block of formatter off. Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Stop making calls to the API server when we don't need to.

8442679

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Restore operator dockerbuild

1769b09

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Fix kroxylicious#2266: Ensure connection is close if SNI hostname fai…

aef28a6

…ls to resolve to virtual cluster. Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Added connection metrics

4b07f93

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

ability to keep the label field empty

0bd59dd

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

fix sonar issues

546a8bd

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

fix test

a31e3e8

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Revert changes

f5425b3

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Add suggestions by Sam

2b97035

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

use greaterThanOrEqual() method

63a3ac7

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

update w.r.t to Keith's changes for SNI handling

d934740

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Added suggestions by Keith and Sam

d7ae6e8

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Update localstack/localstack Docker tag to v4.5.0 (kroxylicious#2274)

b5275ef

Signed-off-by: k-wall <18440250+k-wall@users.noreply.github.com> Co-authored-by: k-wall <18440250+k-wall@users.noreply.github.com> Signed-off-by: Ujjwal <ukalia@confluent.io>

Strimzi Quickstart For Examples (kroxylicious#2275)

ce6be81

Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Ujjwal <ukalia@confluent.io>

Remove duplicate dependency definition

bed49ed

Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

Push operator image for release version

937a5aa

Fixes: kroxylicious#1852 Signed-off-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Ujjwal <ukalia@confluent.io>

ujjwalkalia force-pushed the ssl_principal_propagation branch from 037b011 to b0e4f40 Compare June 8, 2025 21:22

Merge branch 'main' into ssl_principal_propagation

834dfcb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ssl client principal propagation#1

ssl client principal propagation#1
ujjwalkalia wants to merge 84 commits intomainfrom
ssl_principal_propagation

ujjwalkalia commented Jun 2, 2025

Uh oh!

Uzziee Jun 3, 2025

Uh oh!

Uzziee Jun 3, 2025

Uh oh!

Uzziee Jun 3, 2025

Uh oh!

hrishabhg left a comment

Uh oh!

hrishabhg Jun 3, 2025

Uh oh!

hrishabhg Jun 3, 2025

Uh oh!

hrishabhg Jun 3, 2025

Uh oh!

hrishabhg Jun 3, 2025

Uh oh!

hrishabhg Jun 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

	String downStreamCertificatePrincipal();
	String downstreamCertificatePrincipal();

	downStreamCertificatePrincipal = "ANONYMOUS";
	downStreamCertificatePrincipal = ANONYMOUS;

Conversation

ujjwalkalia commented Jun 2, 2025

Type of change

Description

Additional Context

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hrishabhg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants