CUBE-154 - vLLM with guardrails#166
Open
smithjilks wants to merge 5 commits intoultravioletrs:mainfrom
Open
Conversation
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
SammyOina
requested changes
Feb 10, 2026
| ) -> ChatResult: | ||
| final_headers = self._merge_headers() | ||
|
|
||
| model = self._get_model_from_context() or self.model_name |
Contributor
There was a problem hiding this comment.
_get_model_from_context() is called twice per request — redundant, here and 163
Comment on lines
+140
to
+151
| temp_client = ChatOpenAI( | ||
| model=model, | ||
| base_url=str(self.openai_api_base), | ||
| api_key=self.openai_api_key.get_secret_value() if self.openai_api_key else "EMPTY", | ||
| default_headers=final_headers, | ||
| temperature=self.temperature, | ||
| max_tokens=self.max_tokens, | ||
| **self._extract_openai_options(kwargs) | ||
| ) | ||
|
|
||
| return await temp_client._agenerate( | ||
| messages, stop=stop, run_manager=run_manager, **kwargs |
Contributor
There was a problem hiding this comment.
kwargs are passed both to the temp_client constructor (via _extract_openai_options) and to temp_client._agenerate(..., **kwargs) — risk of duplicate/conflicting parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature becuaes it adds vllm support to guardrails
What does this do?
Adds vllm support to guardrails.
Which issue(s) does this PR fix/relate to?
Resolves #154
Have you included tests for your changes?
No.
Did you document any new/modified features?
No.
Notes