Enhance telemetry module with console logging#163
Open
AvatarSD wants to merge 1 commit intoumdlife:mainfrom
Open
Enhance telemetry module with console logging#163AvatarSD wants to merge 1 commit intoumdlife:mainfrom
AvatarSD wants to merge 1 commit intoumdlife:mainfrom
Conversation
AvatarSD
commented
Jun 27, 2025
- Added DJI console logging callback to the TelemetryModule: - Implemented dji_console_callback to forward PSDK logs to RCLCPP - Registered console logger during module initialization - Handles log data safely with proper error checking
- Improved parameter loading in PSDKWrapper:
- Added RCLCPP_INFO logging for all retrieved parameters
- Covers initialization retries, frame names, and data frequencies - Provides better visibility into configuration during startup
- Code organization: - Moved gimbal_angles_callback declaration to a more appropriate location in telemetry.hpp - Added static dji_console_callback utility with proper documentation - Included necessary dji_logger.h header
…logging
1. Added DJI console logging callback to the TelemetryModule:
- Implemented dji_console_callback to forward PSDK logs to RCLCPP
- Registered console logger during module initialization
- Handles log data safely with proper error checking
2. Improved parameter loading in PSDKWrapper:
- Added RCLCPP_INFO logging for all retrieved parameters
- Covers initialization retries, frame names, and data frequencies
- Provides better visibility into configuration during startup
3. Code organization:
- Moved gimbal_angles_callback declaration to a more appropriate location in telemetry.hpp
- Added static dji_console_callback utility with proper documentation
- Included necessary dji_logger.h header
b815b7c to
88ea4ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.