Repository navigation
fix: preserve UMD externals semantics with utoopack - #876
Open
fireairforce wants to merge 1 commit into
Open
fireairforce wants to merge 1 commit into
fireairforce wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UMD builds with
externals: { react: 'React' }work through Webpack's CommonJS and browser-global branches. The utoopack adapter currently forwards'React'unchanged, which makes Pack read onlyglobalThis.React. Consumers that inject dependencies throughrequirereceive an undefined dependency.Convert ordinary external strings to
{ root: name, commonjs: name }, preserving the configured request value for both branches. Apply this consistently to object mappings, a single external name, and top-level arrays. Explicitly typed values, existing objects, script conversion and whitespace-containing values retain their existing conversion paths. The Webpack build path and dependency versions are unchanged.Validation:
pnpm build, Prettier andgit diff --checkpass.Compatibility boundary:
Plain-string externals change observable behavior in CommonJS hosts. A host that only defines the dependency on
globalThisand cannot resolve its configured name throughrequirecould previously load the utoopack bundle; after this fix it fails while trying to load the CommonJS external. This boundary was verified with real old-string and new-object Pack builds. A correctly injected CommonJS dependency changes from failing to working; pure browser-global loading works in both cases. The change follows Webpack UMD semantics, but existing consumers relying on the previous global-only CommonJS behavior need migration. It must not be presented as a zero-impact change.