Repository navigation
docs(skill): place sound effects about twice as often - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Videos used few sound effects: the skill asked for 0–2 per scene, which in practice gave about 1.4 per scene (10 in a 57s video). This raises the guideline to about twice that.
Changes (SKILL.md, "効果音")
soft paper slide swish,soft tick click,short soft marker strike,soft muted denial thud, short low bump) next to the existing fourNo code change: nothing in the scripts limits the number of effects.
Test plan
soft tick click) peaks 9 dB below the narration, about 7 dB quieter than the rest: effects are leveled by their average, and this short dense click has a high average for its peak. That is a leveling issue separate from this change