Repository navigation
feat(check): report small and low-contrast text and short stops in html films - #27
Merged
Merged
Conversation
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the two checks #19 still asked for, text size and contrast, to
motion-render check, and closes the gap in #23 where a stop shorter than 0.4 s was never reported.Closes #23. Part of #19 (this completes its automated checks). Part of #16.
Changes
scripts/snapshot.js(page side): for every element with text of its own, measuresscripts/layout.ts: two new findings for still boxes, with the same two-samples-in-a-row rule as the others:A is 20px, smaller than 24pxA has contrast 2.1:1, needs 4.5:1(3:1 for text 40 px and up, following WCAG's lower bar for large text)checkLayoutsamples every 0.1 s instead of 0.2 s, so a pose held for 0.2 s is reported (check: a stop shorter than 0.4 s is not reported #23). A one-minute film takes about 8 s to check (was about 3 s).references/html-film.md: the new outputs and how to fix them (dark numbers on light badges; 24 px floor for sources and labels; faded text is not measured, so text meant to be read must not be faded).What it found
wif-v4): the step-number badges in the numbered flow, white digits on light teal and blue, at 3.7:1 and 1.9:1. This is the same problemhyperframes checkfound in the Phase 0 spike. No false positives.layout: okafter one fix (a breathing chip sticking out of its dashed slot).Test plan
make check: lint, typecheck, format, knip, quality gate (no new violations)vitest run --coverage: 93 tests pass (layout.ts100% lines)