Repository navigation
docs(skill): decide video length from the content with no upper limit - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the "about 60 seconds" default from the skill. The length now follows the theme's content, with no upper limit, and a length the user gives still wins.
Closes #30. Part of #16.
Changes
SKILL.md: the length default reads "decide from the theme's content; no upper limit. One mechanism: about 60 s (6-9 scenes); a theme with several steps or comparisons: a few minutes". New rule: do not cut the explanation to fit 60 s; for a film over 2 minutes, tell the user up front that rendering takes about 1-2 minutes per minute of video, and go on without asking.README.md/README.ja.md(Usage): no upper limit on length, how the length is chosen, and the render time per minute (1-2 min, depends on cores, seeMOTION_RENDER_PAGES).The render time figure is from after #31: a 194 s film rendered in 324 s with 7 pages, a 57 s film in 35-67 s.
Check with a 3-minute video
A 194 s film on loop engineering (20 scenes, 73 sound effects) was made end to end following the new rule; results are on #30. One problem found there is out of scope here: Lyria returns at most about 3 minutes of BGM, so a longer film's music restarts with a hard cut (#32).
Test plan