Issue #2302 - Implementation of Multi-language and Validation AI Skills#2
Issue #2302 - Implementation of Multi-language and Validation AI Skills#2ShmRayan wants to merge 3 commits into
Conversation
|
Just curious, why is the gv dependency check removed? |
Same for: --json flag |
|
I have updated the code to address your feedback: |
ElwinLiu
left a comment
ElwinLiu
left a comment
There was a problem hiding this comment.
If using npm to build the project, please add node_modules to .gitignore.
Don't submit node_modules to the repo.
|
I've just updated the code based on your feedback @ElwinLiu: |
| @@ -1,21 +1,4 @@ | |||
| # OS files | |||
| .DS_Store | |||
There was a problem hiding this comment.
Don't deleted the original entries, they're intended to be there.
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "devDependencies": { | |||
| "@types/node": "^25.3.0" | |||
There was a problem hiding this comment.
This is unnecessary. The project uses npx -y bun which handles types natively.
| const sourceDir = path.dirname(inputPath); | ||
| const baseFileName = path.basename(inputPath, ".ump"); | ||
| const generatedFiles = readdirSync(sourceDir).filter(f => | ||
| f.startsWith(baseFileName) && |
There was a problem hiding this comment.
This won't work. Umple generates files based on class names inside the .ump file, not the .ump filename.
|
|
||
| if (!generation.success) { | ||
| if (args.json) { | ||
| console.log(JSON.stringify({ success: false, error: "Generation failed", output: generation.output }, null, 2)); |
There was a problem hiding this comment.
Why are other output objects deleted? e.g. inputPath, diagramType
| const baseFileName = path.basename(inputPath, ".ump"); | ||
| const generatedFiles = readdirSync(sourceDir).filter(f => | ||
| f.startsWith(baseFileName) && | ||
| (f.endsWith(".java") || f.endsWith(".php") || f.endsWith(".py") || f.endsWith(".cpp")) |
There was a problem hiding this comment.
Is cpp supported in this pr?
|
Closing the PR as it's been 2 weeks, and the architecture has been refactored. |
2 participants
Description
This PR implements the core AI Skills requested in issue #2302.
Key Features:
main.ts.--type validatemode that captures detailed compiler errors (e.g., Error 1502).SKILL.mdto reflect new capabilities.Fixes #2302