Repository navigation
Auto-merge green Dependabot updates and group the pm toolchain into one daily PR - #17
Merged
Merged
Conversation
…ne daily PR Version bumps of @unbrained/pm-cli, pm-ops and pm-changelog are mechanical. Dependabot now checks npm daily and groups the pm toolchain (and other minor/patch updates) into single pull requests; a least-privilege workflow enables squash auto-merge for every non-major Dependabot PR, so it lands as soon as the required checks pass and a failing bump stays open as a defect. pm item: pm-ado-14nn
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (5)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughDependabot now checks npm dependencies daily and GitHub Actions weekly, with configured update groups. A pull-request workflow enables squash auto-merge for ChangesDependabot automation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Dependabot
participant GitHubActions
participant GitHubCLI
participant GitHubPullRequest
Dependabot->>GitHubPullRequest: Create dependency update pull request
GitHubPullRequest->>GitHubActions: Trigger pull request workflow
GitHubActions->>GitHubActions: Fetch update metadata and check update type
GitHubActions->>GitHubCLI: Request squash auto-merge for qualifying updates
GitHubCLI->>GitHubPullRequest: Enable squash auto-merge
Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue remains; the dependency-update automation is ready for normal merge checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The automation is restricted to Dependabot pull requests in the intended organization, uses a pinned action, and requests GitHub auto-merge rather than forcing a merge. No security bypass is demonstrated. However, update-classification behavior and effective repository merge protections remain insufficiently verified to conclude minimal risk. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideThis PR configures daily Dependabot npm grouping so the pm toolchain advances as one release-oriented PR, adds a narrowly scoped, SHA-pinned workflow that enables squash auto-merge after required checks for the toolchain and other non-major updates, and records the associated pm work item. Repository settings also enable auto-merge and deletion of merged branches. Sequence diagram for grouped Dependabot auto-mergesequenceDiagram
participant Dependabot
participant GitHub
participant Workflow
participant Metadata
participant Checks
Dependabot->>GitHub: Open daily grouped pull request
GitHub->>Workflow: pull_request
Workflow->>Metadata: dependabot/fetch-metadata
Metadata-->>Workflow: dependency-group and update-type
alt pm-toolchain or non-major update
Workflow->>GitHub: gh pr merge --auto --squash
GitHub->>Checks: Run required checks
Checks-->>GitHub: test (22) and test (26) pass
GitHub-->>GitHub: Merge pull request automatically
else Other major update
Workflow-->>GitHub: Leave pull request open for manual review
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
pm item: pm-ado-14nn
Owner
Author
|
@coderabbitai full review |
✅ Action performedFull review finished. |
…sions Review feedback: an update that fetch-metadata cannot classify must not auto-merge, so the condition now requires semver-minor or semver-patch outside the calendar-versioned pm-toolchain group. The job's write scopes are documented, the dependencies group selects every package explicitly, and the item's acceptance criteria name the pm-toolchain exception. pm item: pm-ado-14nn
Owner
Author
|
@coderabbitai full review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.github/dependabot.yml: npm is checked daily;@unbrained/pm-cliandpm-*packages arrive as onepm-toolchainPR, other minor/patch updates as onedependenciesPR. Other ecosystems are unchanged..github/workflows/dependabot-auto-merge.yml: for Dependabot PRs only (and only inunbraind),dependabot/fetch-metadata(SHA-pinned v3.1.0) classifies the update; thepm-toolchaingroup (calendar-versioned, so a year rollover reads as semver-major) and every other non-major update getgh pr merge --auto --squash. Workflow default permissions are{}; the job alone getscontents: write+pull-requests: write.Why
Fleet rule ([companion pm-cli-website-6d05]): a pm CLI release must reach every package without a hand-written certification PR. Branch protection still requires
test (22),test (26), so nothing merges red; a bump that fails CI stays open as a real defect. Major updates still need a person. Same change as the reviewed pilot unbraind/pm-presets#118.pm item
Summary by cubic
Automates merging green Dependabot version bumps so pm CLI releases reach every package without a hand-written certification PR.
.github/dependabot.ymlchecks npm daily, grouping@unbrained/pm-cliandpm-*packages into onepm-toolchainPR and other minor/patch updates into onedependenciesPR..github/workflows/dependabot-auto-merge.ymlenables squash auto-merge for the calendar-versionedpm-toolchaingroup (year rollovers read as semver-major) and for updatesfetch-metadataclassifies as minor or patch; anything unclassified or major waits for a person.unbraindorg, uses least-privilege permissions, and documents why it needs write scopes.pm-ado-14nnand adds a changelog entry.Same change as the reviewed pilot
unbraind/pm-presets#118.Written for commit 63573c0. Summary will update on new commits.
Summary by Sourcery
Automate the safe propagation of Dependabot dependency updates while retaining manual review for major updates outside the pm toolchain.
New Features:
Enhancements:
Chores: