Repository navigation
Test pack and publish prepare paths after launcher updates - #34
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Summary by CodeRabbit
WalkthroughThe launcher regression tests now cover ChangesLauncher lifecycle validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the main change: testing the pack and publish prepare paths after launcher updates. |
| Description check | |
The description directly explains the new pack and publish coverage, test behavior, validation results, and root cause. |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (3 skipped: 3 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Reviewer's GuideThe PR repairs the coverage regression caused by the refreshed prepare launcher by making lifecycle commands explicit in the test harness and adding pack/publish integration coverage against real Git checkouts. The tests verify successful artifact preparation without mutating configured merge drivers or Git config, while accompanying documentation records the root cause, revert proof, isolated npm/Bun validation, and full coverage results. Sequence diagram for artifact prepare integration coveragesequenceDiagram
participant Test as Test harness
participant Checkout as Git checkout
participant Launcher as prepare-merge-driver
participant PMOps as Installed pm-ops
participant Git as Git config
Test->>Checkout: configure drivers through ci path
Test->>Launcher: run prepare with npm_command=pack
Launcher->>PMOps: execute artifact prepare
PMOps-->>Launcher: successful preparation
Launcher-->>Test: prepare succeeds
Test->>Git: verify configured drivers and config
Git-->>Test: unchanged configuration
Test->>Launcher: run prepare with npm_command=publish
Launcher->>PMOps: execute artifact prepare
PMOps-->>Launcher: successful preparation
Launcher-->>Test: prepare succeeds
Test->>Git: verify configured drivers and config
Git-->>Test: unchanged configuration
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Owner
Author
|
@coderabbitai full review Please review head 528c28a, including outside-diff findings. |
✅ Action performedFull review finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot #30 refreshes the canonical pm-ops prepare launcher, adding pack/publish paths that the install-only test harness never executes. CI falls to 99.96% lines / 99.87% branches; the launcher itself misses line 28 and its artifact branch at line 27. This shares its root cause and test design with unbraind/pm-beads#144 and unbraind/pm-changelog#248.
The helper now supplies an explicit npm lifecycle command. Both artifact cases run against real configured Git checkouts and verify successful prepare execution plus byte-preserved Git config. Tests support both template generations. Canonical template equality, dependency pins and coverage thresholds are unchanged.
Before: the bumped tree fails coverage. After: the full bumped tree passes 181/181 tests under each runtime with zero failures, skips, cancellations or todos, and 100% of every configured coverage dimension.
Revert proof: keep the added tests, remove only the helper lifecycle environment injection, and run the launcher coverage gate. It exits 1 at 98.65% lines / 75% branches with line 28 uncovered. Restore the helper and both full release gates pass.
Validation: exact dependency-overlay npm and Bun gates. Each uses a fresh HOME and GIT_CONFIG_GLOBAL=/dev/null plus GIT_CONFIG_NOSYSTEM=1. Commands:
npm run release:checkandbun run release:check. Local full attempts interrupted by host load are not counted as passing evidence. Details:docs/dependabot-root-cause.md.Tracker: pm-ado-qq1p. The item remains open for orchestration review.
The independent statement gate also passed 816/816 statements (100%). Tracker test metadata now resolves its lock directory at runtime instead of retaining a machine-specific path.
The final validation tree differs from the delivered fix revision only by the original dependency/generated-template overlay and its temporary validation workflow. Tracker receipts and documentation are included in this final validation.