Repository navigation
chore(pm): sync GitHub issues (gated) - #154
github-actions[bot] wants to merge 2 commits into
Conversation
|
PR author is in the excluded authors list. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis gated, fail-closed GitHub synchronization imports two tracker issues, writes their issue snapshots and provenance history, and documents the corresponding fixes under the Unreleased changelog without directly pushing main. Flow diagram for gated GitHub issue synchronizationflowchart LR
A[GitHub issues] --> B[Plan import]
B --> C{Completeness and provenance checks}
C -->|pass| D{Privacy gate}
C -->|fail| X[Abort without write]
D -->|pass| E[Write issue snapshots]
E --> F[Write provenance history]
F --> G[Update Unreleased changelog]
D -->|fail| X
G --> H[Propose branch changes]
H -.-> I[main remains unchanged]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="CHANGELOG.md" line_range="7" />
<code_context>
+
+### Fixed
+
+- Enforce the requested brief budget after the final compaction step ([pm-brief-github-7e06b2eb1b44-135](https://github.com/unbraind/pm-brief/blob/main/.agents/pm/issues/pm-brief-github-7e06b2eb1b44-135.toon))
+- Daily Release workflow is failing ([pm-brief-github-7e06b2eb1b44-84](https://github.com/unbraind/pm-brief/blob/main/.agents/pm/issues/pm-brief-github-7e06b2eb1b44-84.toon))
+
</code_context>
<issue_to_address>
**Shipped fixes reappear as new**
When the next release is generated with these entries still under Unreleased, the entries list fixes completed before the latest release, so the next release repeats them as new work. The #84 entry also presents a failure as a fix without describing a repair, leaving readers unsure what changed.
Remove both already-shipped entries from Unreleased; do not list #84 as a fix without an actual repair description.
Also at `CHANGELOG.md:8`.
</issue_to_address>
### Comment 2
<location path="CHANGELOG.md" line_range="7" />
<code_context>
+
+### Fixed
+
+- Enforce the requested brief budget after the final compaction step ([pm-brief-github-7e06b2eb1b44-135](https://github.com/unbraind/pm-brief/blob/main/.agents/pm/issues/pm-brief-github-7e06b2eb1b44-135.toon))
+- Daily Release workflow is failing ([pm-brief-github-7e06b2eb1b44-84](https://github.com/unbraind/pm-brief/blob/main/.agents/pm/issues/pm-brief-github-7e06b2eb1b44-84.toon))
+
</code_context>
<issue_to_address>
**Historical fixes inflate recent metrics**
When a momentum summary is generated within seven days of this sync, `summarizeMomentum` prefers `closed_at` over `completed_at` and uses `created_at` for cycle time, so these imports count as recent closures with zero-day cycles instead of reflecting their GitHub dates.
Preserve the GitHub creation and closure timestamps in the metadata fields used by momentum, or make the reader use the imported source timestamps.
Also at `CHANGELOG.md:8`.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: CHANGELOG.md:7, CHANGELOG.md:7
|
|
||
| ### Fixed | ||
|
|
||
| - Enforce the requested brief budget after the final compaction step ([pm-brief-github-7e06b2eb1b44-135](https://github.com/unbraind/pm-brief/blob/main/.agents/pm/issues/pm-brief-github-7e06b2eb1b44-135.toon)) |
There was a problem hiding this comment.
🟡 Medium · Shipped fixes reappear as new
When the next release is generated with these entries still under Unreleased, the entries list fixes completed before the latest release, so the next release repeats them as new work. The #84 entry also presents a failure as a fix without describing a repair, leaving readers unsure what changed.
Remove both already-shipped entries from Unreleased; do not list #84 as a fix without an actual repair description.
Also at CHANGELOG.md:8.
Prompt for AI agents
In `CHANGELOG.md` at line 7:
**Shipped fixes reappear as new**
When the next release is generated with these entries still under Unreleased, the entries list fixes completed before the latest release, so the next release repeats them as new work. The #84 entry also presents a failure as a fix without describing a repair, leaving readers unsure what changed.
Remove both already-shipped entries from Unreleased; do not list #84 as a fix without an actual repair description.
Also at `CHANGELOG.md:8`.
There was a problem hiding this comment.
The root cause is in pm-github's import and is fixed in unbraind/pm-github#142. Once the caller adopts that release, its next scheduled sync will regenerate this PR.
|
|
||
| ### Fixed | ||
|
|
||
| - Enforce the requested brief budget after the final compaction step ([pm-brief-github-7e06b2eb1b44-135](https://github.com/unbraind/pm-brief/blob/main/.agents/pm/issues/pm-brief-github-7e06b2eb1b44-135.toon)) |
There was a problem hiding this comment.
🟡 Medium · Historical fixes inflate recent metrics
When a momentum summary is generated within seven days of this sync, summarizeMomentum prefers closed_at over completed_at and uses created_at for cycle time, so these imports count as recent closures with zero-day cycles instead of reflecting their GitHub dates.
Preserve the GitHub creation and closure timestamps in the metadata fields used by momentum, or make the reader use the imported source timestamps.
Also at CHANGELOG.md:8.
Prompt for AI agents
In `CHANGELOG.md` at line 7:
**Historical fixes inflate recent metrics**
When a momentum summary is generated within seven days of this sync, `summarizeMomentum` prefers `closed_at` over `completed_at` and uses `created_at` for cycle time, so these imports count as recent closures with zero-day cycles instead of reflecting their GitHub dates.
Preserve the GitHub creation and closure timestamps in the metadata fields used by momentum, or make the reader use the imported source timestamps.
Also at `CHANGELOG.md:8`.There was a problem hiding this comment.
The root cause is in pm-github's import and is fixed in unbraind/pm-github#142. Once the caller adopts that release, its next scheduled sync will regenerate this PR.
ca11e84 to
0f2b6df
Compare
5fb86bf to
6320ae4
Compare
1 participant
Automated pm-github issue synchronization for unbraind/pm-brief.
The import ran with
--gate: the plan was verified for completeness and provenance idempotency before the write, and the proposed tracker change passed the fail-closed privacy gate before anything was committed.mainis never pushed directly.Tracker items changed:
Summary by Sourcery
Synchronize two GitHub issue updates into the project tracker and changelog.
Bug Fixes:
Chores: