Skip to content

Close the launcher entry-guard item now that its fix has merged - #64

Merged
unbraind merged 1 commit into
mainfrom
close-launcher-entry-guard-item
Aug 10, 2026
Merged

unbraind merged 1 commit into
mainfrom
close-launcher-entry-guard-item

Conversation

@unbraind

@unbraind unbraind commented Aug 10, 2026 •

Copy link
Copy Markdown
Owner

Record-keeping only — no source changes.

pm-linear#63 merged the fix but left its
tracking item open. This closes it with the resolution fields the policy requires, and
regenerates the changelog afterwards (closing an item adds it to the release window, so the
regeneration has to follow the close rather than precede it).

What it records

isMainInvocation in the shared scripts/script-launcher.ts caught a realpathSync failure
and returned false. runIfMain reads false as "not the entry point", so the guarded
script never ran and npm run docstring exited 0 having scanned nothing.

This repository was missed by the original fleet sweep because the guard had been refactored
out of scripts/docstring-gate.ts into the shared launcher, which the gate only re-exports —
so a survey keyed on the gate's filename reported it clean.

The both-sides realpathSync comparison was retained: it normalises Windows drive-letter
casing, so only the catch was removed. CodeRabbit confirmed all three properties in review —
the dual-path normalization is unchanged, a different resolvable entry still returns false,
and the new test fails against the prior implementation.

pm items

Summary by Sourcery

Document the launcher entry-guard fix in the changelog and close its associated PM tracking item.

Documentation:

  • Add a changelog entry describing the launcher skipping guarded gates when a path could not be resolved.

Chores:

  • Update and close the pm-linear-lonp tracking item with the required resolution metadata.

Summary by cubic

Closes the pm-linear-lonp tracking item now that PR #63 merged the shared launcher fix (unresolvable paths are propagated so gates can’t exit 0 without running). Regenerates the changelog to include the closed item in the current release window; no source changes.

Written for commit 5c7a4c4. Summary will update on new commits.

Review in cubic

Pull request 63 landed the propagation fix. The item stayed open afterwards,
so this closes it with the resolution fields the policy requires and
regenerates the changelog, which has to follow the close rather than precede
it.
@sourcery-ai

sourcery-ai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR performs project-management record-keeping for the launcher entry-guard fix by closing its tracking item with a fixed resolution and regenerating the changelog so the closed item appears correctly in the release notes, with no source-code behavior changes introduced in this repository.

Flow diagram for closing pm-linear-lonp and regenerating changelog

flowchart TD
  pm_issue[pm-linear-lonp issue]
  close_issue[Set resolution: fixed]
  regen_changelog[Regenerate CHANGELOG.md]
  release_notes[Release notes include launcher guard fix]

  pm_issue --> close_issue
  close_issue --> regen_changelog
  regen_changelog --> release_notes
Loading

File-Level Changes

Change Details Files
Record the resolution of the launcher entry-guard bug in the project-management issue and history, and reflect it in the changelog under Fixed.
  • Update the pm-linear-lonp issue record to mark the item closed with resolution fixed, following policy-required fields.
  • Append or adjust the pm-linear-lonp entry in the JSONL history log to reflect the closure event and resolution.
  • Regenerate CHANGELOG.md so that the pm-linear-lonp fix appears as a Fixed entry describing the shared script launcher gate-skipping bug, and ensure ordering/formatting matches existing changelog conventions.
CHANGELOG.md
.agents/pm/history/pm-linear-lonp.jsonl
.agents/pm/issues/pm-linear-lonp.toon

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown

Greptile Summary

Closes the launcher entry-guard tracking item after its fix merged and regenerates the changelog so the resolved item appears in the release window.

  • Records the closure, fixed resolution, expected and actual results, and supporting note.
  • Appends matching immutable history events.
  • Adds the resolved issue under the changelog’s Fixed section.

Confidence Score: 5/5

The PR appears safe to merge because it changes only consistent tracking metadata and the generated changelog entry.

The issue state, closure history, resolution details, and changelog entry agree, and no executable behavior or security boundary changes.

Important Files Changed

Filename Overview
.agents/pm/history/pm-linear-lonp.jsonl Appends consistent note and closure events, including the required resolution fields and matching state hashes.
.agents/pm/issues/pm-linear-lonp.toon Transitions the tracking item from open to closed and records its resolution, evidence, timestamps, and close reason.
CHANGELOG.md Adds the newly closed launcher entry-guard issue to the Fixed release entries as expected after item closure.

Reviews (1): Last reviewed commit: "docs(pm): close the launcher entry-guard..." | Re-trigger Greptile

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 039ffd6f-f330-4928-b4dc-676576183eb6

📥 Commits

Reviewing files that changed from the base of the PR and between b94fca5 and 5c7a4c4.

📒 Files selected for processing (3)
  • .agents/pm/history/pm-linear-lonp.jsonl
  • .agents/pm/issues/pm-linear-lonp.toon
  • CHANGELOG.md

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where guarded checks could be skipped when a script path could not be resolved.
    • Unresolvable paths now correctly report errors instead of allowing required checks to pass without running.
  • Documentation

    • Added an entry describing this fix in the unreleased changelog.

Walkthrough

The PR records the unresolved-path fix, closes the related issue, documents verification results, and adds an Unreleased changelog entry.

Changes

Unresolved-path fix records

Layer / File(s) Summary
Record fix resolution and verification
.agents/pm/history/pm-linear-lonp.jsonl, .agents/pm/issues/pm-linear-lonp.toon, CHANGELOG.md
The project records document issue closure, fix resolution, verification results, regression-test coverage, and the unresolved-path launcher behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • unbraind/pm-linear#58: Introduced the shared script launcher whose unresolved-path behavior is documented by this PR.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the launcher entry-guard tracking item is being closed after its fix merged.
Description check ✅ Passed The description accurately explains the tracking-item closure, fix context, changelog update, and absence of source changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch close-launcher-entry-guard-item

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@unbraind

Copy link
Copy Markdown
Owner Author

Merging. CodeRabbit's review covers this exact head (5c7a4c4) and reports no actionable comments; all checks green; record-keeping only, no source changes.

Closes pm-linear-lonp, the item behind #63. Worth keeping visible in this repo's history: it was missed by the original fleet sweep because the guard had been refactored out of scripts/docstring-gate.ts into a shared scripts/script-launcher.ts that the gate only re-exports — so a survey keyed on the gate's filename reported this repository clean while it still carried the defect.

@unbraind
unbraind merged commit 5c4b767 into main Aug 10, 2026
8 checks passed
@unbraind
unbraind deleted the close-launcher-entry-guard-item branch August 10, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant