Skip to content

Read-session snapshot hashes collide for distinct non-UTF-8 filenames #112

Closed

Description

@unbraind

Non-blocking finding from the pre-merge review of #110 (src/read_session.rs:430): lossy filename conversion gives identical snapshot hashes for distinct Unix filenames such as tasks/\x80.toon and tasks/\x81.toon with identical contents. Either reject non-UTF-8 filenames with a typed refusal or hash the exact filename bytes, so the certificate's filename guarantee holds. Acceptance: a Unix-only regression with two such files produces distinct hashes (or a typed refusal) and fails on revert.

Activity

  1. unbraind commented on Oct 23, 2026

    @unbraind
    OwnerAuthor

    Fixed in #110 (exact filename bytes are hashed; regressions fail on revert).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions