Skip to content

Cover pm-web's server bootstrap and remaining routes, and ratchet the coverage gate #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unbraind merged 4 commits into from
Sep 18, 2026
Merged

Cover pm-web's server bootstrap and remaining routes, and ratchet the coverage gate #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf9e79c
test: cover server bootstrap and extension commands
unbraind Sep 18, 2026
5f94a38
fix: close streaming clients during shutdown
unbraind Sep 18, 2026
37caa6d
test: stabilize extension branch coverage
unbraind Sep 18, 2026
e4d2ffc
Keep shutting down when one SSE response cannot end
unbraind Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .agents/pm/history/pm-web-ulgy.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,8 @@
{"hash_algorithm":"sha256","ts":"2026-09-18T03:39:21.296Z","author":"pi-agent","author_source":"asserted","agent_harness":"pi","agent_model":"gpt-5.6-sol","agent_model_source":"environment","agent_instance":"3f43cca22c8538dbf0bf9483","agent_provenance":{"model":{"value":"gpt-5.6-sol","source":"environment"},"effort":null,"role":{"value":"implementer","source":"argv"},"topic":null},"op":"close","patch":[{"op":"remove","path":"/metadata/assignee"},{"op":"replace","path":"/metadata/updated_at","value":"2026-09-18T03:39:21.296Z"},{"op":"replace","path":"/metadata/status","value":"closed"},{"op":"add","path":"/metadata/closed_at","value":"2026-09-18T03:39:21.265Z"},{"op":"add","path":"/metadata/completed_at","value":"2026-09-18T03:39:21.265Z"},{"op":"add","path":"/metadata/resolution","value":"Added real HTTP/PostgreSQL/pm-workspace collaboration tests for cross-client SSE delivery, concurrent no-loss writes with valid history, and broad routes/pm.ts lifecycle behavior; ratcheted coverage floors without weakening the branch gate."},{"op":"add","path":"/metadata/expected_result","value":"The collaboration guarantees and pm route command surface are behaviorally covered, npm run release:check passes, and measured coverage floors only move upward."},{"op":"add","path":"/metadata/actual_result","value":"npm run release:check exits 0 with 398/398 tests passing and aggregate src coverage L/B/F 76.82/80.32/73.00; floors are now 76/80/73. Remaining uncovered files and exact lines are recorded in the preceding item comment; public/src remains intentionally unmeasured at 14,884 TypeScript lines."},{"op":"add","path":"/metadata/close_reason","value":"Behavioral coverage tranche delivered and all local release gates pass; remaining 100% work is explicitly inventoried for the next tranche."}],"before_hash":"71ef9c1b5c62341f81e420c85871de0baf2106c1430a18899c1dc4fbcaad00bd","after_hash":"e2fc273e9bf0b64081ffe2145aac1e10a547a1a4a0a772d60d2a314e50c4eb66","item_hash_version":3,"event_class":"substantive","record_hash_version":1,"record_hash":"74dfb60e1b2f8b6f445da8e561644b9607e87460c3a3178b9379e93404d33853"}
{"hash_algorithm":"sha256","ts":"2026-09-18T03:43:37.356Z","author":"pi-agent","author_source":"asserted","agent_harness":"pi","agent_model":"gpt-5.6-sol","agent_model_source":"environment","agent_instance":"3f43cca22c8538dbf0bf9483","agent_provenance":{"model":{"value":"gpt-5.6-sol","source":"environment"},"effort":null,"role":null,"topic":null},"op":"reopen","patch":[{"op":"remove","path":"/metadata/close_reason"},{"op":"remove","path":"/metadata/actual_result"},{"op":"remove","path":"/metadata/expected_result"},{"op":"remove","path":"/metadata/resolution"},{"op":"remove","path":"/metadata/completed_at"},{"op":"remove","path":"/metadata/closed_at"},{"op":"replace","path":"/metadata/updated_at","value":"2026-09-18T03:43:37.356Z"},{"op":"replace","path":"/metadata/status","value":"in_progress"}],"before_hash":"e2fc273e9bf0b64081ffe2145aac1e10a547a1a4a0a772d60d2a314e50c4eb66","after_hash":"4be4dff3693b6aeac7b01bc175decd4ec4fb54cd67275081b15c122d21dbbad9","item_hash_version":3,"message":"Reopened after PR review so remaining acceptance work is not lost","context":{"recurrence":{"reason":"Review correctly identified unfinished index/server bootstrap acceptance coverage; keep the item active for the next tranche.","from_status":"closed","to_status":"in_progress","previous_terminal":{"close_reason":"Behavioral coverage tranche delivered and all local release gates pass; remaining 100% work is explicitly inventoried for the next tranche.","resolution":"Added real HTTP/PostgreSQL/pm-workspace collaboration tests for cross-client SSE delivery, concurrent no-loss writes with valid history, and broad routes/pm.ts lifecycle behavior; ratcheted coverage floors without weakening the branch gate.","expected_result":"The collaboration guarantees and pm route command surface are behaviorally covered, npm run release:check passes, and measured coverage floors only move upward.","actual_result":"npm run release:check exits 0 with 398/398 tests passing and aggregate src coverage L/B/F 76.82/80.32/73.00; floors are now 76/80/73. Remaining uncovered files and exact lines are recorded in the preceding item comment; public/src remains intentionally unmeasured at 14,884 TypeScript lines."}}},"event_class":"substantive","record_hash_version":1,"record_hash":"94d58c69b46bc1e839246dd880dd576a2b275423f37a4de9b6e4fb23da65dad8"}
{"hash_algorithm":"sha256","ts":"2026-09-18T03:43:37.813Z","author":"pi-agent","author_source":"asserted","agent_harness":"pi","agent_model":"gpt-5.6-sol","agent_model_source":"environment","agent_instance":"3f43cca22c8538dbf0bf9483","agent_provenance":{"model":{"value":"gpt-5.6-sol","source":"environment"},"effort":null,"role":null,"topic":null},"op":"comment_add","patch":[{"op":"add","path":"/metadata/comments/5","value":{"created_at":"2026-09-18T03:43:37.813Z","author":"pi-agent","text":"PR review finding accepted: the task remains in_progress because successful src/index.ts and src/server.ts bootstrap coverage and additional positional actions remain unfinished. This PR is a measured ratchet tranche, not completion of the full item."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-09-18T03:43:37.813Z"}],"before_hash":"4be4dff3693b6aeac7b01bc175decd4ec4fb54cd67275081b15c122d21dbbad9","after_hash":"1e4b5df72cc79f33b77776d5c6192e30f5c8587f118e30fc75ca5c3db35378cc","item_hash_version":3,"event_class":"substantive","record_hash_version":1,"record_hash":"9374a7dff4f7b0c7669848c744ade9ec2717a49ee1477e94cc24c82e383bac04"}
{"hash_algorithm":"sha256","ts":"2026-09-18T04:23:30.934Z","author":"pi-agent","author_source":"asserted","agent_harness":"pi","agent_model":"gpt-5.6-sol","agent_model_source":"environment","agent_instance":"daeba66ee0c70117756542f5","agent_provenance":{"model":{"value":"gpt-5.6-sol","source":"environment"},"effort":null,"role":{"value":"implementer","source":"argv"},"topic":null},"op":"claim","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-09-18T04:23:30.934Z"},{"op":"add","path":"/metadata/assignee","value":"pi-agent"}],"before_hash":"1e4b5df72cc79f33b77776d5c6192e30f5c8587f118e30fc75ca5c3db35378cc","after_hash":"ce5e6cb62560bc1f5e4726a8d0146c945658c61ae12196ab9966dc8b76338fd0","item_hash_version":3,"event_class":"substantive","record_hash_version":1,"record_hash":"99551afee87ed8d802b0657505a666a54d492699bd73be26035d657257798da7"}
{"hash_algorithm":"sha256","ts":"2026-09-18T04:47:05.242Z","author":"pi-agent","author_source":"asserted","agent_harness":"pi","agent_model":"gpt-5.6-sol","agent_model_source":"environment","agent_instance":"daeba66ee0c70117756542f5","agent_provenance":{"model":{"value":"gpt-5.6-sol","source":"environment"},"effort":null,"role":null,"topic":null},"op":"comment_add","patch":[{"op":"add","path":"/metadata/comments/6","value":{"created_at":"2026-09-18T04:47:05.242Z","author":"pi-agent","text":"Bootstrap tranche measured with npm run coverage: 400/400 pass; aggregate src L/B/F 80.10/80.05/75.93 (baseline 76.82/80.29/73.00). Real src/server.ts child starts on an ephemeral loopback port against the test PostgreSQL database and temporary PROJECTS_ROOT, answers /healthz, then shuts down gracefully on SIGTERM. Real host command dispatch covers status up/down/degraded, doctor free/occupied port, and stop absent/stale/live PID behavior. Ratcheted floors to L/B/F 80/80/75. Remaining uncovered lines by file: app.ts 77-78,93-94,153-156,182-183,219-221; auth.ts 10-11; board.ts 49; db.ts 20-27,200-204; health.ts 117-118,222-226,355-365; index.ts 27-30,196-211,277,297-298,344-399,460,491-494; oidc.ts 136-138,161-162,164-165,170-171,229-230,299-300,315-316,318-319,327-328,404-405,434-435,441-442,444-445,451-452,567-572; routes/admin.ts 37-39,90-92,107-109,125-127,136-138,149-151,165-167,186-188,202-204,225-227,244-245; routes/auth.ts 84-86,123-125,145-147,161-163,186-188,200-202; routes/extensions.ts 218-229,237-248,256-267; routes/github.ts 120-133,138-161,166-195,249-251,262-264,266-272,274-275,283-290,295-380,385-444,449-466; routes/groups.ts 28-30,60-62,101-103,125-127,143-145,195-197,232-234; routes/oidc.ts 46-52,65-78,91-108,147-152,154-156,163-188,192-247; routes/pm.ts 42-55,71-74,82-93,104-107,167-169,182-184,187-189,191-194,207-213,226-237,287-394,422-452,458,481-484,557-561,592-593,603,766-768,786-788,879-881,916-950,1178-1238,1401-1403,1432-1434,1452-1454,1464-1466,1479-1501,1506-1533,1538-1562,1567-1590,1595-1604,1609-1625,1630-1644,1649-1663,1668-1682,1687-1701,1706-1715,1720-1739,1744-1752,1757-1765,1770-1785,1790-1807,1812-1828,1833-1841,1846-1854,1859-1877,1882-1890,1895-1904,1909-1919,1937-1939,1945-1970,1972-2008,2018-2070,2075-2120,2128-2198,2203-2211,2216-2239,2244-2256,2261-2268,2273-2276,2281-2284,2289-2292,2297-2300,2305-2309,2314-2323,2342-2365,2384-2406,2411-2421,2426-2443,2448-2465,2470-2489,2494-2511,2516-2533,2538-2558,2563-2580,2585-2602,2607-2625,2630-2653,2658-2678,2683-2701,2709-2718,2722-2736,2741-2758,2768-2771,2784-2787,2804-2809; routes/projects.ts 78-80,117-129,137-139,152-154,172-174,191-193; routes/sharing.ts 59-61,156-158,181-183,210-212; server.ts 28-29,70-72,76-77,93-94; services/mutation-event-watcher.ts 109; services/pm-runner.ts 123-130,162-167,207-213,231-233,326-333,367-369,487-488,534-540,566-572,712-714,803-809,876-878,886-888,1006-1007; services/project-watcher.ts 47,156-157,205-206; services/realtime-bus.ts 187-190,192-196,216-221; services/sse.ts 322-323,344-345,405-429. Item remains in_progress because all metrics are not 100."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-09-18T04:47:05.242Z"}],"before_hash":"ce5e6cb62560bc1f5e4726a8d0146c945658c61ae12196ab9966dc8b76338fd0","after_hash":"0905e22ba0a988fb6b354a1fed6d323bb57ebc9d231e33910f8dae51cba3b22d","item_hash_version":3,"event_class":"substantive","record_hash_version":1,"record_hash":"650475e847a9104ebdbce724c8eaa3a382a034dd6386f0b53529438e69058d7b"}
{"hash_algorithm":"sha256","ts":"2026-09-18T04:47:22.708Z","author":"pi-agent","author_source":"asserted","agent_harness":"pi","agent_model":"gpt-5.6-sol","agent_model_source":"environment","agent_instance":"daeba66ee0c70117756542f5","agent_provenance":{"model":{"value":"gpt-5.6-sol","source":"environment"},"effort":null,"role":{"value":"implementer","source":"argv"},"topic":null},"op":"update","patch":[{"op":"add","path":"/metadata/tests/1","value":{"command":"npm run coverage","scope":"project","provenance":{"author":"pi-agent","created_at":"2026-09-18T04:47:22.446Z","source_kind":"local_mutation","source_ref":"test/cover-pm-web-bootstrap-and-remaining-routes"}}},{"op":"add","path":"/metadata/files/2","value":{"path":"test/smoke.test.ts","scope":"project"}},{"op":"add","path":"/metadata/files/3","value":{"path":"src/server.ts","scope":"project"}},{"op":"add","path":"/metadata/files/4","value":{"path":"test/extension.test.ts","scope":"project"}},{"op":"replace","path":"/metadata/updated_at","value":"2026-09-18T04:47:22.708Z"}],"before_hash":"0905e22ba0a988fb6b354a1fed6d323bb57ebc9d231e33910f8dae51cba3b22d","after_hash":"b8f8ef459e8f495cb65fc7b57e8f99f0d40e1fd6e6623d429f55e8d21fab91ed","item_hash_version":3,"event_class":"maintenance","record_hash_version":1,"record_hash":"826dcac23b34a1b1dddf1908d6528ad5c3cdd5fcac77c7f7156755ea1b57f398"}
{"hash_algorithm":"sha256","ts":"2026-09-18T05:12:25.878Z","author":"pi-agent","author_source":"asserted","agent_harness":"pi","agent_model":"gpt-5.6-sol","agent_model_source":"environment","agent_instance":"daeba66ee0c70117756542f5","agent_provenance":{"model":{"value":"gpt-5.6-sol","source":"environment"},"effort":null,"role":null,"topic":null},"op":"comment_add","patch":[{"op":"add","path":"/metadata/comments/7","value":{"created_at":"2026-09-18T05:12:25.877Z","author":"pi-agent","text":"PR review follow-up: accepted both Greptile findings. Graceful signal shutdown now ends and removes all active SSE clients before server.close so streaming responses cannot block shutdown; added direct observable coverage. The live-PID test now tracks its helper child outside the body and always terminates/awaits it in finally. CI also required freshly built tracked dist/server.js and source map, which are included."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-09-18T05:12:25.878Z"}],"before_hash":"b8f8ef459e8f495cb65fc7b57e8f99f0d40e1fd6e6623d429f55e8d21fab91ed","after_hash":"c7c618be24f5b50ea3f3745c6d5efd466c1d18404d095131a8f59f5207a35ea6","item_hash_version":3,"event_class":"substantive","record_hash_version":1,"record_hash":"009beffe99acba2dcdaa0ad8fa95f1fd0994f947d7b6314329b3c6f807ffa520"}
{"hash_algorithm":"sha256","ts":"2026-09-18T05:12:26.831Z","author":"pi-agent","author_source":"asserted","agent_harness":"pi","agent_model":"gpt-5.6-sol","agent_model_source":"environment","agent_instance":"daeba66ee0c70117756542f5","agent_provenance":{"model":{"value":"gpt-5.6-sol","source":"environment"},"effort":null,"role":{"value":"implementer","source":"argv"},"topic":null},"op":"update","patch":[{"op":"add","path":"/metadata/files/5","value":{"path":"src/services/sse.ts","scope":"project"}},{"op":"add","path":"/metadata/files/6","value":{"path":"test/sse.test.ts","scope":"project"}},{"op":"add","path":"/metadata/files/7","value":{"path":"dist/server.js","scope":"project"}},{"op":"add","path":"/metadata/files/8","value":{"path":"dist/server.js.map","scope":"project"}},{"op":"replace","path":"/metadata/updated_at","value":"2026-09-18T05:12:26.831Z"}],"before_hash":"c7c618be24f5b50ea3f3745c6d5efd466c1d18404d095131a8f59f5207a35ea6","after_hash":"e301d0660871aeeb2acf716cf047e8a3550462fe7851131aa009298442613986","item_hash_version":3,"event_class":"maintenance","record_hash_version":1,"record_hash":"c8f1644814cc41c8f64125ab98e6b8a49076b8df5baab2ac0e74537209b2446a"}
Loading
Loading