chore(deps-dev): bump @types/node from 26.6.1 to 26.6.2 - #155
Merged
Merged
Conversation
|
PR author is in the excluded authors list. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: unbraind/pm-web/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
unbraind
added a commit
that referenced
this pull request
Sep 22, 2026
…es, fix all findings (#156) * Certify pm CLI 2026.9.21, adopt canonical pm-ops merge-driver, lint and duplication gates Pin @unbrained/pm-cli to 2026.9.21, pm-changelog to 2026.9.18 and pm-ops to 2026.9.18 (manifest.json pm_min_version follows the SDK pin), and absorb Dependabot #155 (@types/node 26.6.1 in the lockfile). Replace the vendored scripts/prepare-merge-driver.mjs with the thin pm-ops/merge-driver launcher; CI health becomes pm health --strict-exit --require-merge-drivers with no separate merge-install step, because npm ci's prepare hook already installs the drivers. Add scripts/lint.ts and scripts/duplication-gate.ts launchers over pm-ops/eslint and pm-ops/duplication, wire lint + duplication into release:check after typecheck and into CI right after the Type check step, and record duplicationGate {threshold: 0, minTokens: 50}. Fix every lint finding in code: 92 errors before, 0 after. Explicit any sites became typed fixtures or unknown+narrowing (legal-routes, extensions-routes, filters), dynamic imports became top-level imports (app.ts graph/router/utils, filters, plan-execution, i18n, sw-queue, healthz), the window bridge moved into public/src/browser-window.ts, promise executors lost their implicit returns, post-await assignments moved into helper functions, and i18n uses Object.hasOwn. Extract requireProject/projectPm in src/routes/pm.ts (2+ call sites each): duplication 4.31% / 274 pairs before, 3.02% / 160 pairs after this step; the remaining pairs are refactored in follow-up commits. * Add the sw-queue preload helper used by the static service-worker import The queue suite previously installed its IndexedDB/self mocks and then dynamically imported public/src/sw.ts. The mocks now live in test/helpers/sw-queue-preload.ts so a top-level import of the preload module (and then of the worker source) keeps the ordering while satisfying the fleet lint rule that forbids dynamic imports. * Fix remaining lint and duplication findings, complete test refactoring Fix 5 parse errors left by the in-progress refactoring (stray colons in admin-routes, healthz, ephemeral-server, sharing-routes, groups-routes), infinite recursion in withWritableRoot (healthz) and setupCollabTest (pm-collaboration), broken imports in groups-routes and sharing-routes, missing fs harness in projects-routes tests, a missing rate-limit budget exhaustion loop, and a harness.restore/cleanup mismatch in pm-schema-history-routes. Eliminate all 15 remaining duplication clone pairs by extracting shared helpers: withMockedFetch (sw-queue), createShare/deleteShare/setupShareTest (sharing-routes), withDbEnv (pure-units), makeSingleProjectReconciler/ makeDedupeReconciler/makeDualProjectReconciler/setupDedupeTest (mutation-event-watcher), setupGroupTest/addMemberViaApi (groups-routes), assertMalformedUuidMutating (pg-harness, cross-file), authedRequest (ephemeral-server, cross-file), withExtensionsHarness/ assertAllRejectedAndNoSpawn (extensions-routes), setupProjectsTest (projects-routes). Also widen the release publish reconcile window to 20x30s with a 21-attempt bun verification gate (no backfill step). Measured results: lint 0 errors (was 92), duplication 0% / 0 clone pairs (was 4.31% / 274 pairs), coverage 83.03/81.04/76.38 above 79/79/75, 402 tests pass, release:check exits 0. * Register collaboration test teardown before the server starts A startApp() rejection previously skipped t.after registration, leaking the temporary projects root and the PROJECTS_ROOT override into later tests. The server is now held in an optional holder and closed only when started (CodeRabbit review on #156). * Reuse setupCollabTest in the SSE collaboration test The previous commit's start-safe teardown duplicated the SSE test's inline setup, which the 0% duplication gate rejected. The SSE test now registers its stream abort first (node:test runs after-hooks in registration order, so the stream closes before the server) and then uses the shared setup. --------- Co-authored-by: SteveBot <1153461+unbraind@users.noreply.github.com>
Owner
|
@dependabot rebase |
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 26.6.1 to 26.6.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.6.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/node-26.6.1
branch
from
September 22, 2026 21:00
347f466 to
0248d21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @types/node from 26.6.1 to 26.6.2.
Commits