Skip to content

Certify pm CLI 2026.9.23 and adopt the guarded pm-ops merge-driver launcher - #158

Merged
unbraind merged 1 commit into
mainfrom
certify-pm-cli-2026-9-23-and-roll-out-guarded-merge-driver-launcher
Sep 25, 2026
Merged

unbraind merged 1 commit into
mainfrom
certify-pm-cli-2026-9-23-and-roll-out-guarded-merge-driver-launcher

Conversation

@unbraind

@unbraind unbraind commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fleet wave of 2026-09-25 (companion epic pm-cli-website-5s6z), applied by the fleet's deterministic wave script and verified by this repository's own gates.

  • Certify pm CLI 2026.9.23, exact pins in package.json and package-lock.json: pm-ops 2026.9.18 -> 2026.9.23, pm-changelog 2026.9.18 -> 2026.9.23.
  • Guarded merge-driver launcher (companion pm-cli-website-xy19): scripts/prepare-merge-driver.ts is now the template pm-ops 2026.9.23 ships, copied unchanged (it replaces the static-import launcher). It imports nothing from pm-ops, so a production install of a clone (npm ci --omit=dev) skips with one notice instead of dying on ERR_MODULE_NOT_FOUND, while a stale or broken pm-ops still fails the install. prepare-merge-driver.test.ts compares the file byte-for-byte with node_modules/pm-ops/templates/prepare-merge-driver.ts (pm-ops covers every branch of that template with real fixtures) and runs it to prove the drivers register.

pm items

  • pm-web-75mz: Chore, created, closed and released by this PR

Verification

Check Result
git config --get-regexp '^merge\.pm' after npm ci drivers registered
CI health block (pm health ... --require-merge-drivers), executed from ci.yml exit 0
npm run release:check exit 0 (verify-release-publish-attestation: every publish invocation is attested.)
changelog:full then changelog:check regenerated after the pm writes, consistent

Summary by Sourcery

Certify the 2026.9.23 pm CLI dependencies and harden merge-driver installation across development and production clones.

Bug Fixes:

  • Make production installs without devDependencies complete successfully while still failing for stale or broken pm-ops installations.

Enhancements:

  • Adopt the pm-ops 2026.9.23 guarded merge-driver launcher and document its clone-install behavior.

Build:

  • Pin pm-ops and pm-changelog to version 2026.9.23.

Documentation:

  • Update README guidance for the guarded, cross-platform merge-driver setup.

Tests:

  • Add coverage for launcher parity, driver registration, omitted dependencies, stale pm-ops, installer failures, and signal termination.

Chores:

  • Record the associated project-management chore and changelog entry.

Summary by cubic

Certs pm CLI 2026.9.23 and replaces the merge-driver install hook with the guarded launcher pm-ops ships.

  • pm-ops and pm-changelog are pinned from 2026.9.18 to 2026.9.23 in package.json and package-lock.json.
  • scripts/prepare-merge-driver.ts copies the pm-ops launcher template unchanged: it imports nothing from pm-ops, so a production install of a clone (npm ci --omit=dev) skips with one notice instead of dying on ERR_MODULE_NOT_FOUND, while a stale or broken pm-ops still fails the install.
  • test/prepare-merge-driver.test.ts keeps the launcher byte-identical to the pinned template and covers full, omit-dev, and stale pm-ops checkouts.

Written for commit 789eace. Summary will update on new commits.

Review in cubic

…uncher

- Pins pm-ops 2026.9.18 -> 2026.9.23, pm-changelog 2026.9.18 -> 2026.9.23 exactly (package.json and package-lock.json).
- scripts/prepare-merge-driver.ts is now the launcher template pm-ops ships, copied unchanged: it
  imports nothing from pm-ops, so `npm ci --omit=dev` in a clone skips with one notice instead of
  failing, while a stale or broken pm-ops still fails. A test keeps it byte-identical to the pinned
  template and proves it registers the drivers.

pm items: pm-web-75mz. Companion epic pm-cli-website-5s6z. release:check exits 0.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @unbraind, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 3 days and 21 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: unbraind/pm-web/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c307c210-9037-4f27-970c-01b7ec1228c3


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Reviewer's Guide

This PR upgrades pm-ops and pm-changelog to 2026.9.23, adopts pm-ops’s guarded merge-driver launcher so omit-dev installs skip only when pm-ops is absent while real configuration or runtime failures remain fatal, and verifies the exact template plus install behavior in isolated integration fixtures.

Sequence diagram for the guarded merge-driver prepare hook

sequenceDiagram
    participant NPM
    participant Launcher as prepare-merge-driver.ts
    participant Resolver as Node module resolver
    participant PMOps as pm-ops prepare installer
    participant Git as Git config

    NPM->>Launcher: run prepare hook
    Launcher->>Resolver: resolve pm-ops/merge-driver/prepare
    alt pm-ops absent
        Resolver-->>Launcher: MODULE_NOT_FOUND
        Launcher->>Resolver: probe pm-ops/package.json
        Resolver-->>Launcher: MODULE_NOT_FOUND
        Launcher-->>NPM: print notice and exit 0
    else pm-ops installed
        Resolver-->>Launcher: installer path
        Launcher->>PMOps: spawn installer
        PMOps->>Git: pm merge install
        Git-->>PMOps: drivers registered
        PMOps-->>Launcher: exit status
        Launcher-->>NPM: propagate status
    end
Loading

Flow diagram for merge-driver install failure handling

flowchart TD
    A[Run prepare-merge-driver.ts] --> B{Resolve pm-ops installer}
    B -->|Package absent| C[Print skip notice]
    C --> D[Exit successfully]
    B -->|Package installed| E{Installer resolves and runs}
    E -->|Success| F[Merge drivers registered]
    E -->|Stale package or installer failure| G[Fail npm install]
Loading

File-Level Changes

Change Details Files
Certify the pm CLI dependency wave at 2026.9.23.
  • Pin pm-ops and pm-changelog to 2026.9.23 in both manifests.
  • Record the associated chore, history, and changelog entry.
package.json
package-lock.json
.agents/pm/chores/pm-web-75mz.toon
.agents/pm/history/pm-web-75mz.jsonl
CHANGELOG.md
Replace the static pm-ops import with a guarded child-process launcher.
  • Resolve the pm-ops prepare entry from the package root without importing pm-ops.
  • Skip cleanly with one notice only when pm-ops is absent.
  • Propagate stale-package resolution errors and installer failures, including signal termination.
  • Document omit-dev behavior, registry-install behavior, and cross-platform execution.
scripts/prepare-merge-driver.ts
README.md
Add integration coverage for launcher provenance and runtime behavior.
  • Assert the committed launcher matches the pinned pm-ops template byte-for-byte.
  • Exercise full installs, omit-dev installs, stale pm-ops, failing pm installs, and signal termination in isolated Git checkouts.
  • Verify all merge drivers declared by .gitattributes are registered only in the full-install scenario.
test/prepare-merge-driver.test.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@unbraind

Copy link
Copy Markdown
Owner Author

Review round complete before merge. All 0 inline bot threads were answered in-thread, and each was either fixed in this PR or tracked on the companion hub (launcher template: pm-cli-website-dqg7; release-workflow verifier: pm-cli-website-mxrp). Greptile is not installed on this repository. Sourcery skipped this head (its weekly diff allowance), so its earlier findings on this PR are the last it gave, and all were answered. CodeRabbit posted only its free-plan notice: this repository has fewer than 10 stars, so it doesn't review automatically, and its one-review-per-hour allowance is kept for PRs that need it. Every required check is green on 789eace.

@unbraind
unbraind merged commit ac0b1e1 into main Sep 25, 2026
8 checks passed
@unbraind
unbraind deleted the certify-pm-cli-2026-9-23-and-roll-out-guarded-merge-driver-launcher branch September 25, 2026 09:20
@unbraind

Copy link
Copy Markdown
Owner Author

Correction after merge: this PR moved pm-ops and pm-changelog to 2026.9.23, but pm-web's own @unbrained/pm-cli stayed at 2026.9.21. pm-web declares it under dependencies (it runs pm at request time), and the wave script only rewrote devDependencies, so the title's "Certify pm CLI 2026.9.23" was not true for the runtime. #159 moves the dependency, the lockfile and manifest.json pm_min_version to 2026.9.23 (release:check green, 408/408), and the wave script now rewrites both sections.

unbraind added a commit that referenced this pull request Sep 25, 2026
The 2026-09-25 fleet wave (#158) moved pm-ops and pm-changelog to 2026.9.23 but left
@unbrained/pm-cli at 2026.9.21: pm-web declares it under dependencies because it runs pm at
request time, and the wave script only rewrote devDependencies. This moves the runtime
dependency, the lockfile and manifest.json pm_min_version (tests require it to equal the
pinned SDK) to 2026.9.23. release:check exits 0 (408/408 tests). A private copy of all 31
hosted workspaces reads identically under 2026.9.21 and 2026.9.23.

pm item: pm-web-gbuc (companion epic pm-cli-website-5s6z).

Co-authored-by: SteveBot <1153461+unbraind@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant