Skip to content

feature/mesh-nullspace commits are not in development #102

Description

@gthyagi

Current upstream/development does not contain the mesh-nullspace work that is present on upstream/feature/mesh-nullspace.

Missing commits:

  • 2338493b5293dd8c2c61856dd7e66a42b5898bd7 Add nullspace_rotations property to mesh classes
  • 4936d8284dd0f62dda42b3342bb4cfe22cfbebdf Add petsc_use_nullspace convenience property to Stokes solver

I verified that neither commit is an ancestor of current upstream/development.

This seems worth flagging because 4936d828 depends on 2338493b:

  • 2338493b adds mesh.nullspace_rotations
  • 4936d828 uses that to auto-populate stokes.petsc_velocity_nullspace_basis via stokes.petsc_use_nullspace = True

At the moment, development still does not expose mesh.nullspace_rotations or stokes.petsc_use_nullspace, so shell nullspace setup still has to be handled manually.

Tagging @lmoresi for visibility.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions