Skip to content

Stale rotated free-slip datum guard tests in test_0641 (nonzero datum is now implemented, #458) #470

Description

@lmoresi

tests/test_0641_wave_c_api_shims.py::TestRotatedFreeslipValueFirst still asserts that a non-zero rotated free-slip datum raises NotImplementedError:

  • test_nonzero_datum_not_implemented
  • test_symbolic_possibly_nonzero_datum_not_implemented

#458 (merged 2026-07-29) implemented the prescribed-normal datum, so add_rotated_freeslip_bc(1.0, "Top") is now accepted and both tests fail on development.

FAILED tests/test_0641_wave_c_api_shims.py::TestRotatedFreeslipValueFirst::test_nonzero_datum_not_implemented
FAILED tests/test_0641_wave_c_api_shims.py::TestRotatedFreeslipValueFirst::test_symbolic_possibly_nonzero_datum_not_implemented
2 failed, 82 passed

They should assert the new contract instead: a scalar/symbolic datum is accepted and recorded on _rotated_freeslip_bcs, and whatever is still genuinely rejected (vector/matrix values) still raises.

Found while validating the FMG option-bundle unification (#468 / #467); unrelated to that change and not fixed there to keep the diff scoped.

Underworld development team with AI support from Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions