Skip to content

fix(boundary_flux, rotated_bc): guard against empty-but-valid stratum IS (#319) #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmoresi merged 1 commit into from
Jul 5, 2026
Merged

fix(boundary_flux, rotated_bc): guard against empty-but-valid stratum IS (#319) #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/underworld3/utilities/boundary_flux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def _boundary_field_nodes(solver, boundary, field_id=0):
v0, v1 = dm.getDepthStratum(0)
fS, fE = dm.getHeightStratum(1)
sis = _boundary_stratum_is(dm, solver.mesh, boundary)
if sis is None or sis.handle == 0:
if not (sis and sis.getSize() > 0):
return [], lsec, csec, cvec, v0, v1
facets = [int(z) for z in sis.getIndices()]
seen = set(); out = []
Expand Down Expand Up @@ -103,7 +103,7 @@ def _node_normals(solver, boundary, normal, nodes, dm, dim, cvec, csec, v0, v1):
if normal is None:
# accumulate area-weighted facet normals to the closure nodes
sis = _boundary_stratum_is(dm, solver.mesh, boundary)
facets = [] if (sis is None or sis.handle == 0) else [int(z) for z in sis.getIndices()]
facets = [] if not (sis and sis.getSize() > 0) else [int(z) for z in sis.getIndices()]
fS, fE = dm.getHeightStratum(1)
acc = {}
for f in facets:
Expand Down Expand Up @@ -151,7 +151,7 @@ def _desmear(solver, boundary, xs, R, mass, remove_mean, partial_reaction=True):
def vcoord(q): return cvec[csec.getOffset(q) // dim]
nodeR = {_key(x, dim): float(r) for x, r in zip(xs, R)}
sis = _boundary_stratum_is(dm, solver.mesh, boundary)
strat = [] if (sis is None or sis.handle == 0) else [int(z) for z in sis.getIndices()]
strat = [] if not (sis and sis.getSize() > 0) else [int(z) for z in sis.getIndices()]
local_elems = []
for e in [q for q in strat if e0 <= q < e1]:
a, b = (int(c) for c in dm.getCone(e))
Expand Down
2 changes: 1 addition & 1 deletion src/underworld3/utilities/rotated_bc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _boundary_velocity_nodes(solver, boundary, normal=None):
# In parallel a rank may own NO part of this boundary → a null IS; guard and return
# no local nodes (calling getIndices() on a null IS would segfault).
Comment on lines 75 to 76
sis = _boundary_stratum_is(dm, solver.mesh, boundary)
if sis is None or sis.handle == 0:
if not (sis and sis.getSize() > 0):
return []
facets = [int(z) for z in sis.getIndices()]
fS, fE = dm.getHeightStratum(1) # facets (edges in 2D, faces in 3D)
Expand Down
Loading