Design note: the predictor-corrector manager (#689) measured against the implicit scheme - #706
Open
lmoresi wants to merge 1 commit into
Open
Design note: the predictor-corrector manager (#689) measured against the implicit scheme#706lmoresi wants to merge 1 commit into
lmoresi wants to merge 1 commit into
Conversation
…the implicit scheme on the rotating Gaussian Same case as the Eulerian-vs-semi-Lagrangian table: the two-pass CitcomS preset costs what the implicit P1 step costs (0.030 s) and is eight times less accurate; the converged mode is the same implicit system at twenty times the cost per step and three times the error (its steady tau). Runs in ~/+Simulations/supg_vs_slcn_657/rotation_pc/. Underworld development team with AI support from Claude Code Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018T2VHUGaZiQVJ95qQ4DiSL
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is documentation-only and the added subsection/table is well-formed MyST/Markdown and consistent with the surrounding design note style.
Pull request overview
Adds a design-note subsection to the existing Eulerian SUPG transport design doc, extending the rotating-Gaussian “round-trip” comparison table to include the predictor-corrector manager from PR #689 (both citcoms and pc_converged) alongside the implicit EulerianSUPG P1/P2 and SLCN rows.
Changes:
- Documented the
EulerianSUPGPCpredictor-corrector algorithm at a high level (predictor + correction passes, stability-step behavior, P1-only constraints, and integration hook). - Added a like-for-like cost/accuracy comparison table for predictor-corrector vs implicit Crank–Nicolson on P1 at the predictor-corrector stability step.
- Summarized the interpretation of the measured results and positioned the predictor-corrector’s role (CitcomS fidelity rather than cost/accuracy).
File summaries
| File | Description |
|---|---|
| docs/developer/design/eulerian-supg-transport.md | Adds a new subsection and measurement table comparing the #689 predictor-corrector manager against the implicit scheme for the rotating-Gaussian case. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a subsection to
docs/developer/design/eulerian-supg-transport.mdwith the rotating-Gaussian round-trip rows for gthyagi'sEulerianSUPGPC(both modes, at its own stability step) beside the implicitEulerianSUPGmanager on P1 at the same step and the existing P2 and SLCN rows. Runs and driver:~/+Simulations/supg_vs_slcn_657/rotation_pc/on a probe worktree of #689's branch over development 1d5e8c1. Docs only.🤖 Generated with Claude Code
https://claude.ai/code/session_018T2VHUGaZiQVJ95qQ4DiSL