Skip to content

Fix MPI BdIntegral on deformed spherical shells - #99

Merged
gthyagi merged 1 commit into
underworldcode:developmentfrom
gthyagi:bugfix/bdintegral-deformed-shell
Mar 30, 2026
Merged

Fix MPI BdIntegral on deformed spherical shells#99
gthyagi merged 1 commit into
underworldcode:developmentfrom
gthyagi:bugfix/bdintegral-deformed-shell

Conversation

@gthyagi

@gthyagi gthyagi commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • treat empty local boundary strata the same as missing boundary labels in UW_DMPlexComputeBdIntegral
  • add an MPI regression test covering BdIntegral on a deformed spherical shell after _deform_mesh()
  • keep existing parallel annulus boundary-integral coverage passing

Verification

  • mpirun -np 2 /Users/tgol0006/.pixi/bin/pixi run -e amr-dev pytest tests/parallel/test_0765_internal_boundary_integral_mpi.py -q --with-mpi
  • /Users/tgol0006/.pixi/bin/pixi run -e amr-dev pytest tests/test_0502_boundary_integrals.py -q -k spherical

@gthyagi
gthyagi requested a review from lmoresi as a code owner March 30, 2026 01:14

@lmoresi lmoresi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is correct — checks local stratum size before entering the Allreduce path, handling the general case of empty local boundary strata under MPI partitioning. Test covers the deformed-shell scenario that surfaced it. Approved.

@lmoresi lmoresi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an issue that was surfaced when dealing with deforming meshes but which is also quite general and is related to the surface integral code approach that we worked on recently. This should be accepted as is.

@gthyagi
gthyagi merged commit 993ee8e into underworldcode:development Mar 30, 2026
1 check passed
@gthyagi
gthyagi deleted the bugfix/bdintegral-deformed-shell branch April 8, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants