invoice-status uses ensureSync(sphere, 'nostr') — should be 'full' to trigger IPFS pull

[vrogojin]

Summary

src/legacy/legacy-cli.ts case 'invoice-status' calls:

await ensureSync(sphere, 'nostr');

But invoice-status displays per-target balance from on-chain payment attribution, which requires IPFS-pulled state (not just Nostr-pulled inbox). 'nostr' mode doesn't trigger the IPFS / Profile pull, so on a fresh device or after a wipe, invoice-status reports stale or empty status.

The other invoice commands use the right mode:

• case 'invoice-deliver' → ensureSync(sphere, 'full') ✓
• case 'invoice-status' → ensureSync(sphere, 'nostr') ✗ (should be 'full')
• case 'invoice-list' → ensureSync(sphere, 'nostr') (probably also wrong, same reasoning)

Fix

Trivial — change 'nostr' to 'full' in the case 'invoice-status' handler (and probably case 'invoice-list' too, but worth confirming separately):

       case 'invoice-status': {
         ...
         const sphere = await getSphere();
         ...
-        await ensureSync(sphere, 'nostr');
+        await ensureSync(sphere, 'full');
         ...

Note on the deeper bug

This fix alone won't make invoice-status work on a peer that received the invoice via Nostr — that needs sphere-sdk #230 (AccountingModule.invoiceTermsCache refresh on sync:completed). Both fixes are required for the full cross-device flow.

Related

• sphere-sdk #223 comment 4525528875 enumerates this as item 4 of four §C.4 follow-ups
• sphere-sdk #230 — companion SDK-side fix for invoice cache refresh
• Related sphere-cli issue: Migrate from deprecated IpfsStorageProvider to createNodeProfileProviders (Profile + aggregator pointer + IPFS CAR) #23 (IpfsStorageProvider migration) — the IPFS pull this fix unblocks runs over the deprecated provider; once that migration lands, this fix routes through the new Profile path

Acceptance

• invoice-status calls ensureSync(sphere, 'full')
• Audit invoice-list for the same mismatch
• Verify manual-test-full-recovery.sh §C.4 progresses past the "No invoice found matching prefix" error (with sphere-sdk #230 also landed)