fix(e2e): import the shared trustbase URL instead of the deleted testnet.json - #776
Merged
Conversation
…net.json Three suites hardcoded the raw URL of bft-trustbase.testnet.json, deleted upstream as obsolete, and throw on a non-200 -- so each fails at setup with "Failed to download trustbase: 404". The deletion only revealed the defect. That file declared networkId 3 (the retired v1 testnet) while all three pass network: 'testnet', which since #765 aliases testnet2, networkId 4. The oracle derives the engine's network id from the file at trustBasePath, so the engine was being built for a network the gateway does not serve. tests/e2e/support/staging.ts already exports the correct, env-overridable TRUSTBASE_URL (testnet2, networkId 4). Import it -- one definition instead of four, and the network mismatch goes with it. Closes #775
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bft-trustbase.testnet.jsonwas deleted upstream as obsolete. Three e2e suites hardcoded its raw URL andthrowon a non-200, so each now fails at setup withFailed to download trustbase: 404.The deletion only revealed the defect. That file declared
networkId 3(the retired v1 testnet) while all three suites passnetwork: 'testnet'— which since #765 aliases testnet2,networkId 4. The oracle derives the engine's network id from the file attrustBasePath, so the engine was being built for a network the gateway does not serve.tests/e2e/support/staging.tsalready exports the correct, env-overridableTRUSTBASE_URL(testnet2,networkId 4). Importing it collapses four copies of the constant into one and takes the network mismatch with it.Verified: the new URL returns 200 with
networkId: 4; the old one returns 404 cache-busted.typecheck:testsandlintclean. These suites run in no CI job, so nothing went red.Closes #775