Skip to content

fix(styles): stop fade-in from permanently making elements a containing block #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KruGoL merged 1 commit into from
Jul 30, 2026
Merged

fix(styles): stop fade-in from permanently making elements a containing block #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/styles/components.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,16 @@ select.admin-input {

/* ─── Animations ─────────────────────────────────────────────────────── */
@keyframes pulse-glow { 0%, 100% { opacity: 0.4; } 50% { opacity: 0.8; } }
@keyframes fade-in { from { opacity: 0; transform: translateY(6px); } to { opacity: 1; transform: translateY(0); } }
/* The final keyframe MUST end at `transform: none`, not `translateY(0)`.
With `fill-mode: both` the last keyframe's value is retained forever, and a
transform of `translateY(0)` is still a transform — it permanently makes the
element a containing block for `position: fixed` descendants. A dialog
rendered inside an `.animate-fade-in` wrapper then positions itself against
that wrapper instead of the viewport, and on a short page its top ends up
above the screen where it cannot be scrolled to. `none` animates
identically (it interpolates as the identity transform) and leaves no
containing block behind. */
@keyframes fade-in { from { opacity: 0; transform: translateY(6px); } to { opacity: 1; transform: none; } }
.animate-fade-in { animation: fade-in 0.3s ease-out both; }

/* ─── Skeleton ────────────────────────────────────────────────────────── */
Expand Down
Loading