chore: take sphere-ui 0.1.43 so announcements render their body and markdown - #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The announcement modal shipped in this app renders
summaryfor a critical announcement and drops the body — everything an author wrote below the first paragraph never reaches the reader. That is fixed in sphere-ui 0.1.42 (unicity-sphere/sphere-ui#28), and 0.1.43 (unicity-sphere/sphere-ui#29) fixes the markdown around it: fenced code blocks used to render wearing inline code's pill inside an unstyled<pre>, pushing the modal wider than the viewport instead of scrolling; tables, blockquotes,hr,h4–h6and images had no styling at all.The lockfile here still pinned 0.1.41, so neither fix reached anyone regardless of the caret range — hence the explicit bump rather than waiting for an incidental
npm install.What changed
^0.1.43plus the lockfile. No source changes:AnnouncementModal's props and behaviour are unchanged, the newAnnouncementModalCardexport is additive, andreact-markdown/remark-gfmare sphere-ui's own dependencies rather than peers, so nothing new is required here.Verification
tsc --noEmitclean,vitest run— 833 passed (118 files).Note on the jump
This app was on
^0.1.36with its lock at 0.1.41, so the range moves seven versions at once. Everything in between is announcement or packaging work, none of it touching an API this app uses:./announcementssubpath)