chore: take sphere-ui 0.1.44 so authored line breaks survive - #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sphere-ui 0.1.44 (unicity-sphere/sphere-ui#30) makes a single newline in an announcement body render as the line break the author actually typed.
Markdown's own rule is that a lone newline is a space — only a blank line or two trailing spaces break a line. The composer's Body is a plain textarea that says nothing about being markdown, so an author who pressed Enter once watched their two lines silently run together in the delivered announcement.
remark-breakssettles it the way comment fields everywhere do, and leaves code blocks' newlines verbatim.What changed
^0.1.44plus the lockfile. No source changes here.Verification
tsc --noEmitclean.vitest run— 832 passed, 1 failed (118 files).The one failure is
tests/unit/sdk/walletLock/passwordChangeTimeoutPreservation.test.tsx> "a custom timeout chosen before a password Change is still in effect after it", and it is pre-existing on main, not caused by this bump:walletLockfolder runs alone, so it is a timing-sensitive test that times out under full-suite load;SphereProviderand the wallet auto-lock settings.