Skip to content

chore: take sphere-ui 0.1.44 so authored line breaks survive - #483

Merged
KruGoL merged 1 commit into
mainfrom
chore/sphere-ui-0.1.44
Aug 10, 2026
Merged

chore: take sphere-ui 0.1.44 so authored line breaks survive#483
KruGoL merged 1 commit into
mainfrom
chore/sphere-ui-0.1.44

Conversation

@KruGoL

@KruGoL KruGoL commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Why

sphere-ui 0.1.44 (unicity-sphere/sphere-ui#30) makes a single newline in an announcement body render as the line break the author actually typed.

Markdown's own rule is that a lone newline is a space — only a blank line or two trailing spaces break a line. The composer's Body is a plain textarea that says nothing about being markdown, so an author who pressed Enter once watched their two lines silently run together in the delivered announcement. remark-breaks settles it the way comment fields everywhere do, and leaves code blocks' newlines verbatim.

What changed

^0.1.44 plus the lockfile. No source changes here.

Verification

tsc --noEmit clean. vitest run — 832 passed, 1 failed (118 files).

The one failure is tests/unit/sdk/walletLock/passwordChangeTimeoutPreservation.test.tsx > "a custom timeout chosen before a password Change is still in effect after it", and it is pre-existing on main, not caused by this bump:

  • it fails identically with sphere-ui pinned back to 0.1.43 (same test, same ~46s timeout), verified by downgrading and re-running the full suite;
  • it passes when its own file or the whole walletLock folder runs alone, so it is a timing-sensitive test that times out under full-suite load;
  • it imports nothing from sphere-ui \u2014 it exercises SphereProvider and the wallet auto-lock settings.

@KruGoL
KruGoL merged commit 8a59c0a into main Aug 10, 2026
7 of 8 checks passed
@KruGoL
KruGoL deleted the chore/sphere-ui-0.1.44 branch August 10, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant