fix: Follow-ups to the sandbox integration - #491
Merged
Conversation
…rary Signed-off-by: Justin Chadwell <justin@unikraft.com>
Signed-off-by: Justin Chadwell <justin@unikraft.com>
…iven Signed-off-by: Justin Chadwell <justin@unikraft.com>
Signed-off-by: Justin Chadwell <justin@unikraft.com>
Signed-off-by: Justin Chadwell <justin@unikraft.com>
Signed-off-by: Justin Chadwell <justin@unikraft.com>
Signed-off-by: Justin Chadwell <justin@unikraft.com>
jedevc
force-pushed
the
jedevc/fix/sandbox-followups
branch
from
September 4, 2026 15:32
2e88828 to
6153c5a
Compare
jedevc
marked this pull request as ready for review
September 4, 2026 16:16
dragosgheorghioiu
approved these changes
Sep 4, 2026
dragosgheorghioiu
left a comment
dragosgheorghioiu
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Approved-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Comment on lines
+57
to
+63
| // a command that ran on an instance and failed isn't an error of ours, so | ||
| // exit with the status it exited with and print nothing over its output | ||
| exitCode := 0 | ||
| if exited, ok := errors.AsType[*sandbox.ExitError](err); ok { | ||
| exitCode, err = exited.ExitCode(), nil | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
this does make more sense than what i had before
i had the impression it should just swallow the command completely including the exit code
| case c.WaitDelay == 0: | ||
| return c.interrupted() | ||
| case c.WaitDelay > 0: | ||
| if c.WaitDelay > 0 { |
Contributor
There was a problem hiding this comment.
I also have the same exact fix in the shell pr haha https://github.com/unikraft-cloud/cli/pull/463/changes#diff-4058e480aa874118f6965bc58392b3a953c7cbeab37d8982b33cf8f4f0579640R239
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review follow-ups on #458, one fix per commit.
The user-visible ones:
unikraft instance execnow exits with the status its command exited with, so a script can check it, and Ctrl-C waits for that command to die of the interrupt instead of giving up on it at once. Underneath, the two output streams are kept apart — folding them onto stdout is the exec command's choice, not something baked in below it — and standard input that fails part way through closes the command's input rather than leaving acatwaiting on it forever.