fix(workflows): add example with latest version of Nginx - #238
Open
assiaait wants to merge 1 commit into
Open
Conversation
Signed-off-by: Assia AIT LAMALEM <assia.aitlamalem@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates the Nginx example to use a newer “official” runtime and customizes the default landing page, and adds GitHub Actions workflows intended to build/test the example.
Changes:
- Switch
nginx/Kraftfileruntime frombase-compat:latesttoindex.unikraft.io/official/nginx:latest. - Replace the default Nginx welcome HTML with a Unikraft + Nginx “Hello World” page.
- Add two new Nginx example workflows under
nginx/.github/workflows/.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| nginx/rootfs/wwwroot/index.html | Replaces the default Nginx welcome page with a Unikraft-branded greeting. |
| nginx/Kraftfile | Updates the runtime reference for the Nginx example. |
| nginx/.github/workflows/example-nginx-staging.yaml | Adds a staging workflow intended to build/test the Nginx example. |
| nginx/.github/workflows/example-nginx-stable.yaml | Adds a stable workflow intended to build/test the Nginx example. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| spec: v0.6 | ||
|
|
||
| runtime: base-compat:latest | ||
| runtime: index.unikraft.io/official/nginx:latest |
Comment on lines
+1
to
+5
| name: Build and Test Nginx Example - Stable | ||
|
|
||
| on: | ||
| push: | ||
| branches: [add-nginx-latest] |
Comment on lines
+25
to
+27
| - name: Test Nginx | ||
| run: | | ||
| curl http://localhost:8080 |
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
Comment on lines
+1
to
+5
| name: Build and Test Nginx Example - Staging | ||
|
|
||
| on: | ||
| push: | ||
| branches: [staging] |
Comment on lines
+25
to
+27
| - name: Test Nginx | ||
| run: | | ||
| curl http://localhost:8080 |
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.