Add traefik with required libraries and build from source#54
Open
Xidot wants to merge 2 commits intounikraft:masterfrom
Open
Add traefik with required libraries and build from source#54Xidot wants to merge 2 commits intounikraft:masterfrom
Xidot wants to merge 2 commits intounikraft:masterfrom
Conversation
StefanJum
requested changes
Jul 15, 2023
| @@ -0,0 +1,2 @@ | |||
|
|
|||
Comment on lines
+9
to
+11
| *Not installed by the build script.* | ||
|
|
||
| * golang: 1.20.6 |
Member
There was a problem hiding this comment.
Add the installation instructions here (don't go into details, you can just point to a link where people can find instructions).
Comment on lines
+3
to
+5
| This build script downloads the latest version of traefik form the | ||
| corresponding github releases page. To modify the installation version change | ||
| the `version` variable in the `build.sh`. |
Member
There was a problem hiding this comment.
Suggested change
| This build script downloads the latest version of traefik form the | |
| corresponding github releases page. To modify the installation version change | |
| the `version` variable in the `build.sh`. | |
| This build script downloads the latest version of traefik form the corresponding github releases page. | |
| To modify the installation version change the `version` variable in the `build.sh`. |
Use one line per sentence and one sentence per line.
| make clean-webui -C ${appname} | ||
| echo "" | ||
|
|
||
| pushd ${appname} |
Member
There was a problem hiding this comment.
Suggested change
| pushd ${appname} | |
| pushd ${appname} &> /dev/null || exit 1 |
| go build -ldflags "-linkmode 'external' -extldflags '-pie'" -buildmode=pie \ | ||
| ./cmd/traefik | ||
|
|
||
| popd +0 |
Member
There was a problem hiding this comment.
Suggested change
| popd +0 | |
| popd +0 &> /dev/null || exit 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in instruction:
The problem is that it seem
Traefiktries to create a new thread. Unikraft then kills that thread and crashes and there is not much left for us to do here. Pic related to pthread_create bug: