dataplane: vendor knative operator CRDs + buildkit extraConfig knob#441
Open
EngHabu wants to merge 2 commits into
Open
dataplane: vendor knative operator CRDs + buildkit extraConfig knob#441EngHabu wants to merge 2 commits into
EngHabu wants to merge 2 commits into
Conversation
Chart prerequisites split out of the dataplane-integration CI PR (#429) so that PR can stay CI-only. No behavior change for existing deployments — purely additive: - Vendor the two operator.knative.dev CRDs (knativeeventings, knativeservings) into charts/dataplane/crds/ and mirror them to crds/dataplane/ via sync.sh, so the dataplane chart can install the Knative operator stack standalone. 'make check-vendored-crds' passes (14 knative + 1 non-knative CRDs in sync across chart and mirror dirs). - Add imageBuilder.buildkit.extraConfig: extra TOML appended verbatim to buildkitd.toml (defaults to "", a no-op), to configure insecure registries / mirrors. Wired through the imagebuilder configmap. - Filter webhookHostTemplate from the operator configmap's smConfig. - Regenerate dataplane snapshots for the above (helm 4.2.0). Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
Contributor
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
4 tasks
EngHabu
added a commit
that referenced
this pull request
Jun 11, 2026
Vendored knative operator CRDs, the buildkit extraConfig knob, the operator configmap webhookHostTemplate filter, and the regenerated dataplane snapshots now live in #441 (dataplane-chart-prereqs). This keeps #429 a CI-only change. Once #441 merges to main, this branch's dataplane integration test picks the chart changes back up from main. Signed-off-by: Haytham Abuelfutuh <haytham@union.ai> #441 must merge before this PR's integration test can pass.
EngHabu
added a commit
that referenced
this pull request
Jun 11, 2026
The CI's k3d registry is HTTP-only, so buildkit needs imageBuilder.buildkit.extraConfig to push without TLS (the CI override in .github/ci-values/dataplane.yaml already sets the TOML; this adds the chart template that consumes it). This is a CI-specific need — the insecure registry only exists in the integration test — so it lives here rather than in the #441 chart-prereqs split. No-op at default (""), so no snapshot changes. Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
The buildkit extraConfig knob is only needed for the CI's HTTP-only k3d registry, so it lives with the integration-test PR (#429) rather than this general chart-prereqs split. Keeps this PR to the genuinely shared chart changes: vendored knative operator CRDs and the operator configmap webhookHostTemplate filter. Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Chart prerequisites split out of the dataplane-integration CI PR (#429) so that PR can stay CI-only. Purely additive — no behavior change for existing deployments:
operator.knative.devCRDs (knativeeventings,knativeservings) intocharts/dataplane/crds/and mirror them tocrds/dataplane/viasync.sh, so the dataplane chart can install the Knative operator stack standalone.make check-vendored-crdspasses (14 knative + 1 non-knative CRDs in sync across chart and mirror dirs).imageBuilder.buildkit.extraConfig— extra TOML appended verbatim tobuildkitd.toml(defaults to"", a no-op), to configure insecure registries / mirrors. Wired through the imagebuilder configmap.webhookHostTemplatefrom the operator configmap'ssmConfig.tests/run.sh helmpasses locally.Why split
#429 (dataplane integration CI) had grown to ~8.7k-line diff dominated by these chart/CRD changes, which are independent of the CI workflow itself. Landing them here first keeps #429 reviewable as a CI-only change; once this merges, #429 rebases clean and its diff drops to just
.github/+ the CI task scripts.Test
bash tests/run.sh helm— green (snapshots match).🤖 Generated with Claude Code