Add lock on geometry when setting values manually - #51
Merged
Merged
Conversation
When probe geometry is set manually via the .geometry property (e.g. from external element positions), subsequent property setters (pitch, N, radius) triggered update() which silently overwrote the manual geometry with computed positions. This caused coordinate mismatches when integrating with external toolboxes that provide their own element positions. Add a protected lock_geometry flag to uff.probe that is set to true by set.geometry and checked by update() in all probe subclasses. Internal updates reset the lock to false after computing geometry. Cherry-picked from ustb/ustb Bitbucket PR #203 by Anders Vraalstad. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
When integrating with external toolboxes (e.g. GEWH Voluson converter), element positions from the external source were set via .geometry, but then overwritten when .pitch or .radius were set afterwards. This caused coordinate mismatches between probe positions and source/origin definitions.
Cherry-picked from ustb/ustb Bitbucket PR 203 by Anders Vraalstad.
Test plan
Made with Cursor