Skip to content

Updates - #289

Open
tanzr wants to merge 7 commits into
unioslo:masterfrom
tanzr:ast
Open

tanzr wants to merge 7 commits into
unioslo:masterfrom
tanzr:ast

Conversation

@tanzr

@tanzr tanzr commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

Test coverage report, additional topics for rest_framework, memcache for backend

@tanzr
tanzr requested a review from oyvindkolbu April 5, 2019 13:34
Comment thread mregsite/settings.py Outdated
),
'DEFAULT_THROTTLE_RATES': {
'anon': '20/hour',
'user': '100/day'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100/day seems very low. Actually almost a fifth of what an anonymous user can do.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a good number? 1000/hour? 100/minute As a API user, I would like the time period to be short, to be able to quickly recover if a script run amok. It would be horrible to have to wait an entire day before continuing work, after messing up like that.

Comment thread mregsite/settings.py Outdated
'LOCATION': '127.0.0.1:11211',
}
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide instructions on how to run memcached.

Comment thread requirements.txt Outdated
uritemplate==3.0.0
urllib3==1.24.1
coverage==4.5.3
memcached==1.4.15

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line breaks travis. Possibly uneeded.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good tip is to: pip install package .
Then later if you are happy with the package: pip freeze > requirements.txt

@oyvindkolbu

Copy link
Copy Markdown
Collaborator

And also please have better pull request descriptions.

@tanzr tanzr closed this Apr 8, 2019
@tanzr tanzr reopened this Apr 8, 2019
@terjekv

terjekv commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

This has been stale for a long time. It seems to aim for two changes:

  1. Add throttling to the API
  2. Add memcache support

Is there still a desire to have these changes merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants