Conversation
…exclude/get methods
Collaborator
|
coverage: 97.702% (+0.03%) from 97.672% — fix-lowercasemanager-chaining into master |
Member
Author
|
This PR has uncovered a bunch of bugs relating to the lowercasing of queries that was added after the migration from CITEXT in Django 5. They are now documented as failing test cases, but it's not great that we have these bugs - especially for regex queries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
LowerCaseManagerwould be bypassed in views that implemented their ownget_objectmethods. By constructing the manager via a newLowerCaseQuerySet, we now ensure all lookups in views that useLowerCaseManagershare the same underlying lower-casing behavior via the query set itelf.