tags, enh: show roles instead of <R>#187
Conversation
| :type 'string | ||
| :group 'citre) | ||
|
|
||
| (defcustom citre-tag-roles-marker (lambda (roles) |
There was a problem hiding this comment.
I'd suggest changing this to citre-tag-roles-format and it should defaults to <%s>, as I don't think the roles field needs to be transformed in a more complex way (If you need to, please let me know). The propertization can be done in citre--make-tag-annotation-str.
Also, I consider it good to disable roles annotation if this is nil, so users who don't need this behavior can simply set this to nil and have the old behavior.
| "A function marking added for roles of references in tags. | ||
| If a tag has no roles field, use `citre-tag-reference-mark` as fallback. | ||
|
|
||
| The function takes roles as a string and returns a marked string." |
There was a problem hiding this comment.
I've rewrite it a bit, please see if this is easier to understand:
"A format string for roles annotation.
If a tag is a reference tag and has roles field, this is used to format
the roles field of the tag. If this is nil, or the tag doesn't have a
roles field, `citre-tag-reference-mark' is used to indicate that it is a
reference tag."
|
Thanks! I've fixed the CI problem, so you can rebase this on the master branch and it should runs fine. |
masatake
force-pushed
the
show-roles
branch
2 times, most recently
from
f9c8337 to
99ff9d0
Compare
| citre-tags-definition-default-sorter) | ||
| :require '(name ext-abspath pattern) | ||
| :optional '(ext-kind-full line typeref scope extras)))) | ||
| :optional '(ext-kind-full line typeref scope extras |
There was a problem hiding this comment.
I don't think this works. For example:
(setq x t)
'(line ,@(when x '(roles)))
;; => (line (\,@ (when x '(roles))))
`(line ,@(when x '(roles)))
;; => (line roles)| :optional '(ext-kind-full line typeref scope extras | |
| :optional `(ext-kind-full line typeref scope extras |
There was a problem hiding this comment.
Sorry for the mistake. Updated.
Close universal-ctags#186 Signed-off-by: Masatake YAMATO <yamato@redhat.com>
|
Thanks! |
2 participants
Close #186