Skip to content

Remove Popover's default-override of elementContext: reference #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bendemboski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Popover's default-override of elementContext: reference #808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions ember-primitives/src/components/popover.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { FloatingUI } from "../floating-ui.ts";
import type { Signature as FloatingUiComponentSignature } from "../floating-ui/component.gts";
import type { Signature as HookSignature } from "../floating-ui/modifier.ts";
import type { TOC } from "@ember/component/template-only";
import type { ElementContext, Middleware } from "@floating-ui/dom";
import type { Middleware } from "@floating-ui/dom";
import type { ModifierLike, WithBoundArgs } from "@glint/template";

export interface Signature {
Expand Down Expand Up @@ -220,20 +220,13 @@ function maybeAddArrow(middleware: Middleware[] | undefined, element: Element |
return result;
}

function flipOptions(options: HookSignature["Args"]["Named"]["flipOptions"]) {
return {
elementContext: "reference" as ElementContext,
...options,
};
}

export const Popover: TOC<Signature> = <template>
{{#let (ArrowElement) as |arrowElement|}}
<FloatingUI
@placement={{@placement}}
@strategy={{@strategy}}
@middleware={{maybeAddArrow @middleware arrowElement.current}}
@flipOptions={{flipOptions @flipOptions}}
@flipOptions={{@flipOptions}}
@shiftOptions={{@shiftOptions}}
@offsetOptions={{@offsetOptions}}
as |reference floating extra|
Expand Down
Loading