Migrate docs to kolay + @universal-ember/docs-support - #19
Merged
NullVoxPopuli merged 1 commit intoJul 20, 2026
Merged
NullVoxPopuli merged 1 commit into
NullVoxPopuli merged 1 commit into
Conversation
Replaces the @crowdstrike/ember-oss-docs + docfy docs stack with the universal-ember org's docs setup, as used by ember-primitives and @universal-ember/table: - docs-app is now a strict-resolver vite app (@embroider/vite's ember() on vite 8, ember-source 7, no tailwind — docs-support 0.9.11 is self-styled; a tiny utility-class block covers the demos) - all doc content moved from docs/ (docfy markdown + separate demo folders) into docs-app/src/templates/**/*.gjs.md (kolay), with every docfy demo rewritten as a single live-rendered gjs component - package names updated throughout (ember-headless-form -> @universal-ember/form and friends) - the ember-changeset demo now uses plain validator functions with lookupValidator from validated-changeset: ember-changeset-validations is a v1 addon and cannot load in a vite app - verified in a real browser: landing page, nav, prose, shiki highlighting, and the live demos (yup validation errors render with correct aria; custom-control id/label wiring and prefill work) Fallout fixed along the way: - @glimmer/component v1 is gone from the workspace (packages' devDeps now v2): its presence made pnpm's .pnpm/node_modules fallback hand glint's invokability augmentation a different copy than consumers use - input/field constructors type owner as Owner (gc2 signature) - @babel/plugin-syntax-dynamic-import was a phantom dependency of the packages' rollup builds, provided transitively by the removed docs stack — now declared - babel needs @warp-drive/build-config setConfig (ember-data enters the docs-app graph via ember-changeset v5) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
@crowdstrike/ember-oss-docs+ docfy docs stack with the universal-ember org's docs setup, following ember-primitives and@universal-ember/table. Verified locally: fullturbo build lint test typecheckgreen across the workspace, and the built site was loaded in a real browser — landing page, kolay nav, shiki-highlighted code, and live demos all work (the yup demo renders validation errors with correct aria on submit; the custom-control demo's id/label wiring and value prefill work).docs-app
@embroider/vite'sember()on (rolldown-)vite 8, ember-source 7,ember-strict-application-resolver, kolay for routing/markdown,@universal-ember/docs-support0.9.11 for the Shell/PageLayout/IndexPage chrome./tailwindexport and ships its own styles (this is the ember-primitives shape; table is still on 0.9.2 + tailwind). A ~60-line utility block inapp.csscovers the demo markup's classes.docs/(docfy markdown + separatedemo/folders) intodocs-app/src/templates/**/*.gjs.md, with every docfy two-fence demo (hbs template+js component) rewritten as a single live-rendered gjs component. Package names updated throughout (ember-headless-form→@universal-ember/form& friends).lookupValidatorfromvalidated-changeset—ember-changeset-validationsis a v1 addon and can't load in a vite app (prose still points at it for classic apps).docs/directory is removed;glint-name-error.pngmoved topublic/.Workspace fallout fixed along the way
@glimmer/componentv1 is fully gone (packages' devDeps → v2; peer ranges already allowed it since Migrate test-app to vite (ember.nvp-style), scenario-test via @embroider/try, drop TS 5.9 #18). Its mere presence in the workspace made pnpm's.pnpm/node_modulesfallback hand glint's invokability augmentation a different copy of@glimmer/componentthan consumers resolve → 18[Invoke]-missing errors in the addon's own typecheck once docs-app's copy was the last v1. With v1 gone the identity is unambiguous everywhere.input.gts/field.gtsconstructors now typeownerasOwner(gc2's constructor signature).@babel/plugin-syntax-dynamic-importwas a phantom dependency of the packages' rollup builds — provided transitively by the removed crowdstrike/docfy tree; now declared where used.@warp-drive/build-config'ssetConfig(ember-data enters the graph via ember-changeset v5), same as test-app.@glint/environment-ember-loosepeer-ignore rule; added anallowedVersionsrule for@glint/template(ember-primitives/ember-repl pin an exact version).Notes for review
projectNameis stillember-headless-form— say the word if you want it repointed at a differently-named project.pnpm startin docs-app gives the vite dev server; there is no test suite for docs-app (same as table's docs-app effectively — its testem setup was vestigial here).🤖 Generated with Claude Code