Deploy docs the way ember-primitives does (wrangler + trusted PR previews) - #20
Merged
NullVoxPopuli merged 1 commit intoJul 20, 2026
Conversation
- ci.yml: the old publish job (cloudflare/pages-action@v1, secret-gated, crowdstrike-era UX_OSS_* secret names) becomes two jobs: 'Build: Docs' runs everywhere and uploads the dist artifact, 'Deploy: Production' (main only) downloads it and publishes via cloudflare/wrangler-action `pages deploy --project-name=ue-form` (matching table's ue- naming) - deploy-preview.yml: trusted workflow_run-triggered preview deploys for PRs, ported from ember-primitives — only the Build job touches PR code (no secrets), the deploy job only handles the built artifact, and a sticky comment posts the preview URL; also manually dispatchable by PR number Requires the ue-form Cloudflare Pages project plus CLOUDFLARE_API_TOKEN / CLOUDFLARE_ACCOUNT_ID repo secrets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports ember-primitives' deploy setup, replacing the crowdstrike-era
cloudflare/pages-action@v1job and its unconfiguredUX_OSS_*secrets.ci.yml
Build: Docsruns on every push/PR (so the docs build stays CI-validated, fork PRs included) and uploadsdocs-app/distas an artifact.Deploy: Production(main only) downloads the artifact and publishes withcloudflare/wrangler-action@v4:pages deploy --project-name=ue-form— following table'sue-project naming.deploy-preview.yml (new)
The primitives trusted-workflow pattern for fork-safe PR preview deploys:
workflow_runwhen CI starts (or manually by PR number viaworkflow_dispatch).determinePRresolves the PR (including fork PRs, wherepull_requests[]is empty, via head-SHA lookup).pages deploy --branch=<pr-branch>for a Cloudflare branch preview; a sticky comment posts the preview URL to the PR.What you need to do for this to light up
ue-formCloudflare Pages project (direct-upload).CLOUDFLARE_API_TOKENandCLOUDFLARE_ACCOUNT_IDsecrets to this repo (same ones primitives/table use).Until then:
Build: Docspasses everywhere;Deploy: Productionwill fail on main pushes with an auth error (it's no longer skip-gated — silent skipping is how the old setup rotted unnoticed), and preview deploys will fail at the wrangler step. Also notedeploy-preview.ymlonly takes effect after this merges (workflow_run reads the workflow from the default branch).🤖 Generated with Claude Code