Test against ember 6.12 LTS, and fix the release/beta/canary scenarios - #203
Merged
NullVoxPopuli merged 3 commits intoSep 27, 2026
Merged
NullVoxPopuli merged 3 commits into
NullVoxPopuli merged 3 commits into
Conversation
ember-source 7 is a v2 addon with development/production export conditions, which broke the vite-app scenarios for release, beta, and canary. - ember-cli 7.3: 6.9 reads classic vendor files from ember-source - remove ember-cli-htmlbars and bump tracked-built-ins to 4.1.2: both pulled in classic ember-cli-htmlbars, which asks ember-source for the template compiler path - babel-plugin-ember-template-compilation 4 without compilerPath, like the current app blueprint - .env.development sets NODE_ENV=development, so the test build resolves the development build of ember-source and assertions run - ember-try runs the test:ember script - bump @embroider/*, @ember/test-helpers, and ember-qunit to the blueprint versions; test-helpers 5.5 renders sooner, so one getPromiseState test now waits for its async function to settle Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@NullVoxPopuli is attempting to deploy a commit to the universal-ember Team on Vercel. A member of the Team first needs to authorize it. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Sep 25, 2026
5.5.1 renders from the render queue of an autorun, like the legacy outlet path (emberjs/ember-test-helpers#1576), so the test passes unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Sep 27, 2026
NullVoxPopuli
approved these changes
Sep 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
ember-lts-6.12scenario and fixesember-release,ember-beta, andember-canary. Those now run ember-source 7.3, 7.4, and 7.5, and they failed on main.ember-source 7 is a v2 addon with
development/productionexport conditions. The vite-app needed these changes to build and test against it:ember-cli6.9 → 7.3. 6.9 reads classic vendor files from ember-source and crashes.ember-cli-htmlbars, and bumpedtracked-built-insto 4.1.2 to drop itsember-tracked-storage-polyfill. Both brought in the classicember-cli-htmlbars, which asks ember-source for a template compiler path that no longer exists.babel-plugin-ember-template-compilation4, with nocompilerPath, like the current app blueprint.tests/vite-app/.env.developmentwithNODE_ENV=development.vite build --mode developmentstill setsNODE_ENV=production, so the test build got the production ember-source andassertfrom@ember/debugdid nothing.modifier() must be invoked with a functionfailed for that reason.test:emberscript, not plainember test.@embroider/*,@ember/test-helpers(to 5.5.1), andember-qunitto the blueprint versions. 5.5.0 painted synchronously insiderender()on ember 6.8+, which broke thegetPromiseState"handles async function" test. 5.5.1 fixes that (Render via renderComponent from the render queue, like the legacy outlet path emberjs/ember-test-helpers#1576), so no test changes are needed.Checked locally:
ember try:onepasses 103/103 for 5.12, 6.4, 6.8, 6.12, release, beta, and canary, and the defaultpnpm test:emberpasses too. After the 5.5.1 bump: default, 5.12, 6.8, 6.12, release, beta, and canary pass 103/103. Thetest-appandmin-supportedapps did not change.🤖 Generated with Claude Code