Modernize the test harness: vite + ember-source 7 - #132
Merged
Merged
Conversation
Rebuilds the test-app following ember.nvp's minimal-app + qunit layer: - vite 8 + @nullvoxpopuli/ember-vite instead of ember-cli/broccoli - ember-source 7.x, ember-strict-application-resolver, gts route templates - ember-qunit 9 + testem ci against the vite build output - @glint/ember-tsc (with ember-source's own types) for type checking, replacing @types/ember* + glint 1 in the test app - a local anchor-click handler in the application template replaces ember-primitives' @properLinks (visitAllLinks needs in-app links to route through the router) CI drops the ember-try matrix (ember-try doesn't apply to the vite harness) in favor of Lints + Tests jobs on node 24. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replaces the hand-rolled anchor-click handler with the @properLinks router decorator (as the classic test-app had), upgrading ember-primitives to a version compatible with ember-source 7 and adding its ember-modifier / ember-resources peers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the test harness that ember.nvp generates (minimal-app base + qunit layer), getting the tests running on ember 7+.
test-app
@nullvoxpopuli/ember-vitereplaces ember-cli / broccoliember-source@^7.0.0(resolves to 7.1.0),ember-strict-application-resolver,.gtsroute templatesember-qunit@^9+testem cirunning against the vite build output (build:test→test:ci, same scripts as the nvp qunit layer)@glint/ember-tsc+ember-source/types, replacing@types/ember*+ glint 1 in the test app (the library's own build/lint pipeline is unchanged)@properLinks—visitAllLinksneeds plain in-app anchors to route through the router, and this avoids pulling ember-primitives' whole peer graph into the harness@universal-ember/test-supportthrough the injected workspace dep, so they exercise the builtdist)CI
Lints+Testsjobs on node 24 (nvp github-actions layer shape)The published package is untouched: same rollup + glint 1 build, same
peerDependencies(ember-source >= 3.28).All 5 tests pass locally on ember-source 7.1.0, and
pnpm lintpasses across the workspace.🤖 Generated with Claude Code