properly ignore deprecated headers field to work with prowlarr - #11
Merged
Conversation
Prowlarr's form POST sends the deprecated headers field as an object, and 1.6.0 refused it because the field is annotated as a list. FlareSolverr v1 declared it as a header map, v2 dropped it, and upstream only warns when it arrives, so no client has a reason to send a list. - Form POSTs from Prowlarr are no longer refused before a solve starts - The field stays unread, so exempting it lets nothing new reach an engine - The class annotation is left as upstream wrote it, so dtos.py still syncs
Adds the regression test for the headers fix, using the shape Prowlarr's form POST sends, and the CHANGELOG entry for it. The test fails with the exemption removed.
unseensnick
force-pushed
the
patch-1
branch
from
September 11, 2026 18:17
3da495e to
2226ddd
Compare
Owner
|
Thanks for this, and for tracking down the shape Prowlarr's form POST sends. Merged with your commit kept under your name. Two things changed on the way in: I reworded the commit message to the repo's |
6 tasks
|
I life it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.