Repin DiffusionGemma to the commit that merges cleanly - #206
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repin
ggml-org/llama.cpp#24423(DiffusionGemma) fromc6f8d604to168b21ad.Why
The publishing run
34108333979failed inResolve tag:Same shape as #205, different pin. The base moved from
b10825tob10830and asecond pinned PR collided with the newer upstream tree, in the same file both times:
tests/test-llama-archs.cpp.The conflict is one hunk, and
additive_merge.pywas right to refuse it, because thebase line already existed and both sides edited it:
Union of the two additions, keeping the DIFFUSION_GEMMA comment.
168b21adis thatmerge on the PR branch; ggml-org#24423 has gone from
CONFLICTINGtoMERGEABLE.Every pin checked against the new base this time
Rather than fix one and rediscover the next on the following run, I merged all
thirteen pins onto
b10830individually:c6f8d604ggml-org#2442336df1bf4ggml-org#25731b9b8207fggml-org#27754So this should be the last blocker for the set.
Verification
Against the resolved tree:
libllama.soandllama-commonbuild clean, andtest-llama-archsbuilds and exits 0.Note on the pattern
This is now twice in two days, both in
tests/test-llama-archs.cpp, both "upstreamadded an architecture to a list while one of our pinned PRs added its own". It will
recur every time the base advances past a pinned PR that touches that list. Worth
considering separately whether
additive_merge.pyshould handle a disjunction orcomma list where the merge base is non-empty but each side only appended a distinct
term; I have deliberately not changed it here, because loosening a guard that
currently refuses to guess is a bigger decision than unblocking a release.