add pyproject support - #148
Conversation
Adjust action to use an up-to-date version of ubuntu
update docker compose command
|
@ldko @somexpert Sorry for all of the commits. Dependabot needs a Would we prefer a Pipfile.lock? Or a pyproject.toml / pyproject.lock instead? |
|
@ldko @somexpert Hi! This is ready for review. I’ve added a pyproject.toml to manage dependencies and environments and integrated Poetry. Poetry now handles dependency installation and uses poetry.lock for locking versions. Also it is Dependabot readable! Several redundant files have been removed and their configuration consolidated into pyproject.toml:
I’ve also updated Docker Compose to install and use Poetry inside the container. There should be no changes required to the existing workflow for installation or running tests. |
… app installations, update README
|
@ldko @somexpert This is ready for a review. This MR does a few things
We also talked about handling vulnerabilities when we are notified by just changing the value in pyproject.toml. No lock files here! |
ldko
left a comment
There was a problem hiding this comment.
This is working well for me. Installed/ran locally ("traditionally") on RHEL and in Docker.
Additional notes:
- To avoid the message:
WARN[0000] /tmp/django-name/docker-compose.yml: the attributeversionis obsolete, it will be ignored, please remove it to avoid potential confusion, we should delete the first line in docker-compose.yml. - When merging this PR, we should select
Squash and mergefrom the dropdown, since there are a lot of irrelevant commits. - It would be helpful to rename this PR, since the current title is no longer accurate.
…in docker and tox
|
@ldko Made the suggested changes.
|
|
@ldko Your suggestions have been addressed |
ldko
left a comment
There was a problem hiding this comment.
Thank you, Trey! Please remember when merging this PR, to select Squash and merge from the dropdown, since there are a lot of irrelevant commits.
somexpert
left a comment
There was a problem hiding this comment.
Just a couple small comments above. Also let's provide a minimum for pytest-cov as we had discussed.
|
@somexpert I went ahead and kept the |
Dependabot needs a .lock file to determine dependency versions. There are other types of .lock files supported, but Pipfile.lock was the easiest to create as it supports requirements.txt. Seeing if Dependabot will the newly added files and suggestion upgrades.