ci: add 'make check' GitHub Actions workflow + ShellCheck hardening - #6
Merged
Merged
Conversation
Run 'make check' (ShellCheck + bats) on PRs to main and pushes to main. Fix an unquoted conditional expansion, a self-assignment, and a word-split loop so the scripts start ShellCheck-clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHrdPEhFSuvzutLvD5xTmS
- build-and-push.sh: replace 'A && B || die' with explicit if (SC2015) - common.sh: drop unreachable 'exit 0' from the sourced-only double-source guard (SC2317) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHrdPEhFSuvzutLvD5xTmS
…r agent - Jenkinsfile: run on 'docker' label (unraid-docker permanent agent) since kaniko cannot do buildx multi-arch / QEMU / docker run. Default GHCR_OWNER=untraceablez, NOTIFY_EMAIL; use a configurable SonarQube installation (SONARQUBE_INSTALLATION, default 'SonarQube-Public') because the in-cluster Sonar URL is unreachable from the off-cluster VM; sonar creds come from withSonarQubeEnv (drop nonexistent credential IDs). - quality-gate.sh: accept SONAR_AUTH_TOKEN (what withSonarQubeEnv injects); run the scanner via the sonarsource/sonar-scanner-cli container when no native binary. - tests: unset SONAR_AUTH_TOKEN in the fail-closed assertion. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHrdPEhFSuvzutLvD5xTmS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5 (which merged before this commit landed).
What
.github/workflows/ci.yml— runsmake check(ShellCheck + bats) on every PR tomainand on pushes tomain.fetch-source.sh: build the auth header via an array (no unquoted conditional expansion), remove a redundant self-assignment.tests/smoke/run-image.sh: iterate platforms viaread -rainstead of unquoted word-splitting.Why
The gating CI was authored after #5 was already merged, so
maincurrently has the automation layer but no CI. This restores the intended test gate. This PR's own run exercises the workflow end-to-end (ShellCheck + the four bats suites).🤖 Generated with Claude Code