feat(backend): Define and Document Item History & Location Logic #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivjd
requested changes
Dec 11, 2025
Contributor
vivjd
left a comment
vivjd
left a comment
There was a problem hiding this comment.
Looking great! Just one minor change and it should be good to go
backend/inventory/utils.py
Outdated
| - No location-changing events: Returns None. This is expected for items that have | ||
| only workflow events (MOVE_REQUESTED, MOVE_APPROVED, etc.) but no actual location | ||
| changes yet. However, every item should ideally have at least an INITIAL event. |
Contributor
There was a problem hiding this comment.
No location-changing events: Returns None.
This sounds like that if there are no location events regardless of there's an initial event, the function will return None (whereas in reality it will return the initial event if it's present). So maybe change it to something like "no location-changing events and initial event is not present".
Author
There was a problem hiding this comment.
Hey Vivian, just implemented some changes. Please let me know if I should revise further.
vivjd
approved these changes
Jan 7, 2026
Contributor
vivjd
left a comment
vivjd
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Formalizes how
ItemHistorydetermines an item’s current location.Related Issues
Changes
get_current_locationto identify events that update true location (INITIAL,ARRIVED,VERIFIED,CORRECTION)get_current_locationHow to Test
Checklist