Bug - Footer #54
Merged
Bug - Footer #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jordanjanakievski
left a comment
jordanjanakievski
left a comment
There was a problem hiding this comment.
Looks good. Text is a little small are the larger screens but I don't hate it. Maybe another opinion would be good.
…tblueprint/website-v2 into alexlewis/intl-35-bug-footer
Contributor
Author
|
I've changed the text sizing a bit but I don't have a screen that wide so please let me know if it looks better. |
Member
jordanjanakievski
left a comment
jordanjanakievski
left a comment
There was a problem hiding this comment.
Final thing. Missed this the first time. Font is looking good to me right now
jordanjanakievski
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/uoft-blueprint-internal/issue/INTL-35/bug-footer
create footer that works on mobile view and remove the extra white space