[Bulk actions workflow]: Updates for MouseEvent / added Chevron up & down to contextual menu#640
Merged
OwenCoogan merged 5 commits intofeature/bulk-action-workflowfrom Feb 19, 2026
Merged
Conversation
OwenCoogan
force-pushed
the
oc/DRA-4477
branch
from
ae6645e to
bc26f77
Compare
OwenCoogan
force-pushed
the
feature/bulk-action-workflow
branch
2 times, most recently
from
9e19fb7 to
9899fcf
Compare
OwenCoogan
force-pushed
the
oc/DRA-4477
branch
from
bc26f77 to
abe9160
Compare
OwenCoogan
force-pushed
the
oc/DRA-4477
branch
from
abe9160 to
31bdc60
Compare
OwenCoogan
commented
Feb 18, 2026
| @action | ||
| callAction(action: ContextMenuItem['action']): void { | ||
| const returnValue = action?.(); | ||
| callAction(action: ContextMenuItem['action'], eventOrValue?: MouseEvent | boolean): void { |
Contributor
Author
There was a problem hiding this comment.
this is from the typing on the context menu action
OwenCoogan
changed the title
edouardmisset
approved these changes
Feb 18, 2026
Miexil
reviewed
Feb 19, 2026
| @action | ||
| callAction(action: ContextMenuItem['action']): void { | ||
| const returnValue = action?.(); | ||
| callAction(action: ContextMenuItem['action'], eventOrValue?: MouseEvent | boolean): void { |
| assert.dom('[data-control-name="context-menu"]').hasText(this.label); | ||
| }); | ||
|
|
||
| test('it shows chevron-down when closed and chevron-up when open', async function (assert) { |
Member
There was a problem hiding this comment.
should be added in the module('When clicking on the button', function () { down in the file and can be split into two separate tests there. (there already is a "When clicking a second time on the button" module in there too)
Contributor
Author
There was a problem hiding this comment.
Moved down in the when clicking on the button
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/needs-review
labels
Miexil
reviewed
Feb 19, 2026
| callAction(action: ContextMenuItem['action']): void { | ||
| const returnValue = action?.(); | ||
| callAction(action: ContextMenuItem['action'], event?: MouseEvent): void { | ||
| const returnValue = action?.(event ?? undefined); |
Member
There was a problem hiding this comment.
isn't event already undefined if not passed in the params ? 🤔
don't think the ?? undefined but might be mistaken
aprentout
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to: #
What are the observable changes?
Good PR checklist