Skip to content

fix(operator): urbex-op never pulls a localhost/* image - #117

Merged
Teg79 merged 1 commit into
mainfrom
fix/urbex-op-local-images
Nov 18, 2026
Merged

Teg79 merged 1 commit into
mainfrom
fix/urbex-op-local-images

Conversation

@Teg79

@Teg79 Teg79 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • tools/operator/urbex-op, need_image: a missing image is pulled only if it names its registry (ghcr.io/urbforge/urbex-op:0.1.0). One built here is never pulled, and gets the hint to build it (urbex-op build or mise run operator-image):

    • podman's localhost/..., localhost:<port>/...;
    • docker's bare name (urbex-operator).

    Before, any name with a / was pulled, localhost/... included.

  • tools/operator/test-urbex-op.sh (new): urbex-op with a fake podman or docker on a minimal PATH that logs the calls, so the real engine is never found. Eight cases: published image missing (pulled) or present (run), localhost/ and localhost:5000/ missing (never pulled), localhost/ present (run), docker bare name missing (never pulled) or present (run), docker published missing (pulled).

  • mise.toml: mise run test (so CI) runs it.

  • tools/operator/README.md: the rule.

Why

#114, found in the Forgejo spike: with URBEX_OPERATOR_IMAGE=localhost/urbex-operator-forgejo not built yet, urbex-op tried to pull it from a registry at localhost and failed.

Tests I ran

  • bash tools/operator/test-urbex-op.sh: 8 ok. The same test against the previous urbex-op: 3 fail (localhost/ and localhost:5000/ pulled, docker's bare name refused with the old message), so it catches the bug.
  • mise run test: passes, the new test included.
  • Not run: docker for real on a Mac (the fake covers docker's naming).

Checklist before review

  • Linked issue, Conventional Commit title
  • Tests added
  • No secrets, tokens or private addresses

Fixes #114

🤖 Generated with Claude Code

https://claude.ai/code/session_0182yxsfwRowwnxCfgrQwjnA

A missing image is pulled only if it names its registry (ghcr.io/...): one built here - localhost/... with podman, a bare name with docker - gets the hint to build it. tools/operator/test-urbex-op.sh checks both engines, in mise run test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0182yxsfwRowwnxCfgrQwjnA
@Teg79
Teg79 marked this pull request as ready for review November 17, 2026 19:49
@Teg79
Teg79 merged commit f5391ab into main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(operator): urbex-op never pulls a localhost/* image

2 participants