Repository navigation
fix(operator): urbex-op never pulls a localhost/* image - #117
Merged
Merged
Conversation
A missing image is pulled only if it names its registry (ghcr.io/...): one built here - localhost/... with podman, a bare name with docker - gets the hint to build it. tools/operator/test-urbex-op.sh checks both engines, in mise run test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0182yxsfwRowwnxCfgrQwjnA
Teg79
marked this pull request as ready for review
November 17, 2026 19:49
stefanoghinelli
approved these changes
Nov 18, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/operator/urbex-op,need_image: a missing image is pulled only if it names its registry (ghcr.io/urbforge/urbex-op:0.1.0). One built here is never pulled, and gets the hint to build it (urbex-op buildormise run operator-image):localhost/...,localhost:<port>/...;urbex-operator).Before, any name with a
/was pulled,localhost/...included.tools/operator/test-urbex-op.sh(new): urbex-op with a fake podman or docker on a minimalPATHthat logs the calls, so the real engine is never found. Eight cases: published image missing (pulled) or present (run),localhost/andlocalhost:5000/missing (never pulled),localhost/present (run), docker bare name missing (never pulled) or present (run), docker published missing (pulled).mise.toml:mise run test(so CI) runs it.tools/operator/README.md: the rule.Why
#114, found in the Forgejo spike: with
URBEX_OPERATOR_IMAGE=localhost/urbex-operator-forgejonot built yet, urbex-op tried to pull it from a registry atlocalhostand failed.Tests I ran
bash tools/operator/test-urbex-op.sh: 8 ok. The same test against the previousurbex-op: 3 fail (localhost/andlocalhost:5000/pulled, docker's bare name refused with the old message), so it catches the bug.mise run test: passes, the new test included.Checklist before review
Fixes #114
🤖 Generated with Claude Code
https://claude.ai/code/session_0182yxsfwRowwnxCfgrQwjnA